Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 2626023005: Revert of Refactoring of RTCP options in BaseChannel. (Closed)

Created:
3 years, 11 months ago by keishi
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Refactoring of RTCP options in BaseChannel. (patchset #4 id:60001 of https://codereview.webrtc.org/2622613004/ ) Reason for revert: Broke Mac64 Release [large tests] build https://build.chromium.org/p/client.webrtc/builders/Mac64%20Release%20%5Blarge%20tests%5D/builds/10576 Original issue's description: > Refactoring of RTCP options in BaseChannel. > > Previously, BaseChannel supported a "no RTCP" mode, which wasn't > being used any more and is being deleted. > > Also, "RTCP mux required" previously worked by calling "ActivateRtcpMux" > after construction. Now it works by explicitly passing a > "require_rtcp_mux" parameter into the constructor. > > BUG=None > > Review-Url: https://codereview.webrtc.org/2622613004 > Cr-Commit-Position: refs/heads/master@{#16045} > Committed: https://chromium.googlesource.com/external/webrtc/+/ac22f70906175831270b399e20d0519198ac6922 TBR=pthatcher@webrtc.org,deadbeef@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+309 lines, -159 lines) Patch
M webrtc/api/rtcstatscollector_unittest.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M webrtc/api/rtpsenderreceiver_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/api/statscollector_unittest.cc View 17 chunks +17 lines, -17 lines 0 comments Download
M webrtc/api/webrtcsession.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/webrtcsession.cc View 10 chunks +30 lines, -13 lines 0 comments Download
M webrtc/pc/channel.h View 8 chunks +17 lines, -11 lines 0 comments Download
M webrtc/pc/channel.cc View 9 chunks +35 lines, -19 lines 0 comments Download
M webrtc/pc/channel_unittest.cc View 42 chunks +162 lines, -51 lines 0 comments Download
M webrtc/pc/channelmanager.h View 6 chunks +6 lines, -6 lines 0 comments Download
M webrtc/pc/channelmanager.cc View 9 chunks +16 lines, -16 lines 0 comments Download
M webrtc/pc/channelmanager_unittest.cc View 3 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
keishi
Created Revert of Refactoring of RTCP options in BaseChannel.
3 years, 11 months ago (2017-01-13 06:29:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2626023005/1
3 years, 11 months ago (2017-01-13 06:29:59 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-13 06:30:00 UTC) #5
Taylor Brandstetter
On 2017/01/13 06:30:00, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
3 years, 11 months ago (2017-01-13 07:16:34 UTC) #6
keishi
3 years, 11 months ago (2017-01-13 07:18:31 UTC) #7
On 2017/01/13 07:16:34, Taylor Brandstetter wrote:
> On 2017/01/13 06:30:00, commit-bot: I haz the power wrote:
> > No L-G-T-M from a valid reviewer yet. 
> > CQ run can only be started by full committers or once the patch has
> > received an L-G-T-M from a full committer.
> > Even if an L-G-T-M may have been provided, it was from a non-committer,
> > _not_ a full super star committer.
> > Committers are members of the group "project-webrtc-committers".
> > Note that this has nothing to do with OWNERS files.
> 
> Are you sure that this CL could have caused the problem? It looks like it's
> failing to find "/Users/chrome-bot/goma/gomacc", and this CL doesn't touch any
> build files.

Sorry it was the only one in the regression range. Closing

Powered by Google App Engine
This is Rietveld 408576698