Rename fec_tables_xor.h -> fec_rate_table.h

Rename fec_tables_xor.h -> fec_rate_table.h

This is a slightly more descriptive name, since we only have one type
of erasure code (XOR), and we only have one table.

BUG=None

Review-Url: https://codereview.webrtc.org/2625903004
Cr-Commit-Position: refs/heads/master@{#16032}
Committed: https://chromium.googlesource.com/external/webrtc/+/71b1c1fc1dc57b63388871566c71711c8126eab7

[brandtr, 2017-01-12 08:26:24]

brandtr@webrtc.org changed reviewers:
+ sprang@webrtc.org

[sprang_webrtc, 2017-01-12 10:37:12]

Maybe out of scope for this cl, but do we really need to have this huge blob of
static data, or can it be calculated on the fly? Feels like it's bad for code
size and memory footprint..

https://codereview.webrtc.org/2625903004/diff/1/webrtc/modules/video_coding/f...
File webrtc/modules/video_coding/fec_rate_table.h (right):

https://codereview.webrtc.org/2625903004/diff/1/webrtc/modules/video_coding/f...
webrtc/modules/video_coding/fec_rate_table.h:24: static const unsigned char
kFecRateTable[kFecRateTableSize] = {
Was this data previously duplicated, or where did the data in fec_tables_xor.h
go?

https://codereview.webrtc.org/2625903004/diff/1/webrtc/modules/video_coding/m...
File webrtc/modules/video_coding/media_opt_util.cc (right):

https://codereview.webrtc.org/2625903004/diff/1/webrtc/modules/video_coding/m...
webrtc/modules/video_coding/media_opt_util.cc:312: assert(indexTable <
kFecRateTableSize);
nit: rtc_check_lt since you're touching this line anyway

[brandtr, 2017-01-12 11:51:52]

Patchset #2 (id:20001) has been deleted

[brandtr, 2017-01-12 11:55:59]

On 2017/01/12 10:37:12, språng wrote:
> Maybe out of scope for this cl, but do we really need to have this huge blob
of
> static data, or can it be calculated on the fly? Feels like it's bad for code
> size and memory footprint..

We could possibly rewrite this static table as a function instead. That would
require reverse engineering the expression used to create the table in the first
place though, because  the script that did that is lost. (I verified this with
the original author a couple of months ago.)

In the future, we may spend some time in refactoring and updating the FEC rate
calculation logic, so I'll defer this change until then.
 
>
https://codereview.webrtc.org/2625903004/diff/1/webrtc/modules/video_coding/f...
> File webrtc/modules/video_coding/fec_rate_table.h (right):
> 
>
https://codereview.webrtc.org/2625903004/diff/1/webrtc/modules/video_coding/f...
> webrtc/modules/video_coding/fec_rate_table.h:24: static const unsigned char
> kFecRateTable[kFecRateTableSize] = {
> Was this data previously duplicated, or where did the data in fec_tables_xor.h
> go?
> 
>
https://codereview.webrtc.org/2625903004/diff/1/webrtc/modules/video_coding/m...
> File webrtc/modules/video_coding/media_opt_util.cc (right):
> 
>
https://codereview.webrtc.org/2625903004/diff/1/webrtc/modules/video_coding/m...
> webrtc/modules/video_coding/media_opt_util.cc:312: assert(indexTable <
> kFecRateTableSize);
> nit: rtc_check_lt since you're touching this line anyway

[brandtr, 2017-01-12 11:56:19]

https://codereview.webrtc.org/2625903004/diff/1/webrtc/modules/video_coding/f...
File webrtc/modules/video_coding/fec_rate_table.h (right):

https://codereview.webrtc.org/2625903004/diff/1/webrtc/modules/video_coding/f...
webrtc/modules/video_coding/fec_rate_table.h:24: static const unsigned char
kFecRateTable[kFecRateTableSize] = {
On 2017/01/12 10:37:11, språng wrote:
> Was this data previously duplicated, or where did the data in fec_tables_xor.h
> go?

This is the same data -- I just renamed the array to a name that I found more
descriptive. So I have both renamed a file, and this table inside that file.

https://codereview.webrtc.org/2625903004/diff/1/webrtc/modules/video_coding/m...
File webrtc/modules/video_coding/media_opt_util.cc (right):

https://codereview.webrtc.org/2625903004/diff/1/webrtc/modules/video_coding/m...
webrtc/modules/video_coding/media_opt_util.cc:312: assert(indexTable <
kFecRateTableSize);
On 2017/01/12 10:37:11, språng wrote:
> nit: rtc_check_lt since you're touching this line anyway

Done.

[sprang_webrtc, 2017-01-12 11:59:04]

lgtm

[brandtr, 2017-01-12 11:59:15]

The CQ bit was checked by brandtr@webrtc.org

[commit-bot: I haz the power, 2017-01-12 11:59:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-12 14:16:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484222355027900,
"parent_rev": "7f9c7d9b45982ab3fea86b8966a298762dff01b6", "commit_rev":
"71b1c1fc1dc57b63388871566c71711c8126eab7"}

[commit-bot: I haz the power, 2017-01-12 14:16:27]

Description was changed from

==========
Rename fec_tables_xor.h -> fec_rate_table.h

This is a slightly more descriptive name, since we only have one type
of erasure code (XOR), and we only have one table.

BUG=None
==========

to

==========
Rename fec_tables_xor.h -> fec_rate_table.h

This is a slightly more descriptive name, since we only have one type
of erasure code (XOR), and we only have one table.

BUG=None

Review-Url: https://codereview.webrtc.org/2625903004
Cr-Commit-Position: refs/heads/master@{#16032}
Committed:
https://chromium.googlesource.com/external/webrtc/+/71b1c1fc1dc57b63388871566...
==========

[commit-bot: I haz the power, 2017-01-12 14:16:28]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/71b1c1fc1dc57b63388871566...