Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2624573004: Add advice about Optional function arguments (Closed)

Created:
3 years, 11 months ago by kwiberg-webrtc
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M webrtc/base/optional.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
kwiberg-webrtc
3 years, 11 months ago (2017-01-10 09:43:01 UTC) #2
hlundin-webrtc
lgtm
3 years, 11 months ago (2017-01-10 09:55:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2624573004/1
3 years, 11 months ago (2017-01-10 10:09:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/b3f7dbc7a5ce05f57958c23f4ca7fff09d24a66d
3 years, 11 months ago (2017-01-10 10:11:21 UTC) #8
minyue-webrtc
3 years, 11 months ago (2017-01-10 10:39:23 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698