Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2624423003: Replace default locale with US locale on Android. (Closed)

Created:
3 years, 11 months ago by sakal
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace default locale with US locale on Android. This fixes a lint warning and also fixes potential bugs on devices running locales where toLowerCase and toUpperCase don't behave as expected. BUG=webrtc:6597 R=magjed@webrtc.org TBR=kjellander@webrtc.org Review-Url: https://codereview.webrtc.org/2624423003 Cr-Commit-Position: refs/heads/master@{#16092} Committed: https://chromium.googlesource.com/external/webrtc/+/037b93af1719bd35ebf08cdfc2b6691b61a29f88

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M webrtc/build/android/suppressions.xml View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/sdk/android/api/org/webrtc/EglRenderer.java View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/sdk/android/api/org/webrtc/SessionDescription.java View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sakal
PTAL
3 years, 11 months ago (2017-01-12 09:58:23 UTC) #1
magjed_webrtc
lgtm
3 years, 11 months ago (2017-01-12 12:09:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2624423003/1
3 years, 11 months ago (2017-01-16 11:55:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/037b93af1719bd35ebf08cdfc2b6691b61a29f88
3 years, 11 months ago (2017-01-16 12:57:36 UTC) #11
kjellander_webrtc
3 years, 11 months ago (2017-01-19 14:50:16 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698