Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2624073003: Rename incoming_framerate_ to capture_framerate_ in screenshare_layers. (Closed)

Created:
3 years, 11 months ago by sprang_webrtc
Modified:
3 years, 11 months ago
Reviewers:
hta-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename incoming_framerate_ to capture_framerate_ in screenshare_layers. Avoids confusion about the meaning of "incoming". BUG=webrtc:6897 Review-Url: https://codereview.webrtc.org/2624073003 Cr-Commit-Position: refs/heads/master@{#16007} Committed: https://chromium.googlesource.com/external/webrtc/+/0ad0de6ef00a50a193da3238d4d0e9feef8d46a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M webrtc/modules/video_coding/codecs/vp8/screenshare_layers.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/screenshare_layers.cc View 3 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
sprang_webrtc
3 years, 11 months ago (2017-01-11 11:41:25 UTC) #2
hta-webrtc
lgtm
3 years, 11 months ago (2017-01-11 11:46:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2624073003/1
3 years, 11 months ago (2017-01-11 11:47:45 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 13:01:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/0ad0de6ef00a50a193da3238d...

Powered by Google App Engine
This is Rietveld 408576698