webrtc/p2p/base/dtlstransportchannel.cc - Issue 2623473004: Replace all use of the VERIFY macro.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/p2p/base/dtlstransportchannel.cc

Issue 2623473004: Replace all use of the VERIFY macro. (Closed)

Patch Set: Delete a DCHECK, instead log and return failure. And fix compile error in previous patch set. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/p2p/base/dtlstransportchannel.cc

diff --git a/webrtc/p2p/base/dtlstransportchannel.cc b/webrtc/p2p/base/dtlstransportchannel.cc

index 575ec327b982dbe3c61e3f7a6e98e35a4f6e9a00..0359954a112ef07a2e812fd7e5bb05334e5ac59c 100644

--- a/webrtc/p2p/base/dtlstransportchannel.cc

+++ b/webrtc/p2p/base/dtlstransportchannel.cc

@@ -354,7 +354,8 @@ bool DtlsTransport::SetSrtpCryptoSuites(const std::vector<int>& ciphers) {

return true;

}

- if (!VERIFY(dtls_state() == DTLS_TRANSPORT_NEW)) {

+ if (dtls_state() != DTLS_TRANSPORT_NEW) {

+ LOG(LS_ERROR) << "Can't set SRTP ciphers for a closed session";

return false;

}