Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/base/diskcache.cc

Issue 2623473004: Replace all use of the VERIFY macro. (Closed)
Patch Set: Delete a DCHECK, instead log and return failure. And fix compile error in previous patch set. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/asyncsocket.h ('k') | webrtc/base/httpclient.cc » ('j') | webrtc/pc/webrtcsdp.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/diskcache.cc
diff --git a/webrtc/base/diskcache.cc b/webrtc/base/diskcache.cc
index 4b3ec5feff8cfe7b2514d36698a98836d043e297..2747018d17473547d2c3bab52884c336b865f999 100644
--- a/webrtc/base/diskcache.cc
+++ b/webrtc/base/diskcache.cc
@@ -26,11 +26,7 @@
#include "webrtc/base/stringencode.h"
#include "webrtc/base/stringutils.h"
-#if !defined(NDEBUG)
-#define TRANSPARENT_CACHE_NAMES 1
-#else
-#define TRANSPARENT_CACHE_NAMES 0
-#endif
+#define TRANSPARENT_CACHE_NAMES RTC_DCHECK_IS_ON
namespace rtc {
@@ -214,7 +210,7 @@ bool DiskCache::DeleteResource(const std::string& id) {
}
bool DiskCache::CheckLimit() {
-#if !defined(NDEBUG)
+#if RTC_DCHECK_IS_ON
// Temporary check to make sure everything is working correctly.
size_t cache_size = 0;
for (EntryMap::iterator it = map_.begin(); it != map_.end(); ++it) {
« no previous file with comments | « webrtc/base/asyncsocket.h ('k') | webrtc/base/httpclient.cc » ('j') | webrtc/pc/webrtcsdp.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698