Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/base/socketadapters.cc

Issue 2623473004: Replace all use of the VERIFY macro. (Closed)
Patch Set: Tweaks after reviewing diff to master. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/base/physicalsocketserver.cc ('K') | « webrtc/base/signalthread.h ('k') | webrtc/base/sslstreamadapter_unittest.cc » ('j') | webrtc/base/sslstreamadapter_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/socketadapters.cc
diff --git a/webrtc/base/socketadapters.cc b/webrtc/base/socketadapters.cc
index 0a9498261339e7cc1385abd65b449c71addb0b12..d152b3fbb5fa599afea7737bf94e74aa2d85b4bd 100644
--- a/webrtc/base/socketadapters.cc
+++ b/webrtc/base/socketadapters.cc
@@ -185,8 +185,8 @@ int AsyncSSLSocket::Connect(const SocketAddress& addr) {
void AsyncSSLSocket::OnConnectEvent(AsyncSocket * socket) {
RTC_DCHECK(socket == socket_);
// TODO: we could buffer output too...
- VERIFY(sizeof(kSslClientHello) ==
- DirectSend(kSslClientHello, sizeof(kSslClientHello)));
+ int res = DirectSend(kSslClientHello, sizeof(kSslClientHello));
+ RTC_DCHECK(sizeof(kSslClientHello) == res);
kwiberg-webrtc 2017/02/07 09:39:49 RTC_DCHECK_EQ
nisse-webrtc 2017/02/07 10:48:15 Done.
}
void AsyncSSLSocket::ProcessInput(char* data, size_t* len) {
« webrtc/base/physicalsocketserver.cc ('K') | « webrtc/base/signalthread.h ('k') | webrtc/base/sslstreamadapter_unittest.cc » ('j') | webrtc/base/sslstreamadapter_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698