Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2622233002: Remove backwards compatibilty path for OpenH264 v1.4 (Closed)

Created:
3 years, 11 months ago by sprang_webrtc
Modified:
3 years, 11 months ago
Reviewers:
hta-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove backwards compatibilty path for OpenH264 v1.4 Deps have rolled to 1.6, and since no one noticed that the old code path was broken and wouldn't even compile, I assume no one is using it. I therefore deem it time to clean away all these nasty ifdefs. ("const kNalHeaderSizeAllocation = 50;" doesn't declare a type) BUG=chromium:614970 Review-Url: https://codereview.webrtc.org/2622233002 Cr-Commit-Position: refs/heads/master@{#16008} Committed: https://chromium.googlesource.com/external/webrtc/+/10418acb9790a82aa8f8368c8d6ba2459747149b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -20 lines) Patch
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc View 2 chunks +1 line, -20 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
sprang_webrtc
Old code path won't even compile, so I'm assuming it's not needed anymore.
3 years, 11 months ago (2017-01-11 11:59:00 UTC) #2
hta-webrtc
lgtm joyfully!
3 years, 11 months ago (2017-01-11 12:15:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2622233002/1
3 years, 11 months ago (2017-01-11 12:35:19 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 13:52:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/10418acb9790a82aa8f8368c8...

Powered by Google App Engine
This is Rietveld 408576698