Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2621163006:
replay: output rtp header elements for errors (Closed)
|
Created:
3 years, 11 months ago by fippo Modified:
3 years, 10 months ago Reviewers:
stefan-webrtc CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
Descriptionreplay: output rtp header elements for errors
outputs various elements of the RTP header when there is a delivery error.
output example:
Packet len=984 pt=100 seq=47914 ts=1532364329 ssrc=0xdeadbef0
BUG=webrtc:6991
Review-Url: https://codereview.webrtc.org/2621163006
Cr-Commit-Position: refs/heads/master@{#16294}
Committed: https://chromium.googlesource.com/external/webrtc/+/7b589600324ee7bc9a5b025482f6bc0c547ed24d
Patch Set 1 #Patch Set 2 : output more header elements #Messages
Total messages: 20 (13 generated)
Description was changed from
==========
replay: output rtp sequence number for errors
outputs the RTP sequence number of the packet when there
is a delivery error.
BUG=
==========
to
==========
replay: output rtp header elements for errors
outputs various elements of the RTP header when there is a delivery error.
==========
Description was changed from
==========
replay: output rtp header elements for errors
outputs various elements of the RTP header when there is a delivery error.
==========
to
==========
replay: output rtp header elements for errors
outputs various elements of the RTP header when there is a delivery error.
output example:
Packet len=984 pt=100 seq=47914 ts=1532364329 ssrc=0xdeadbef0
==========
philipp.hancke@googlemail.com changed reviewers: + stefan@webrtc.org
minor improvement after this tool proved to be very helpful. The output format is similar to the rtpdump one.
The CQ bit was checked by stefan@webrtc.org
lgtm Awesome, thanks.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/12300)
Description was changed from
==========
replay: output rtp header elements for errors
outputs various elements of the RTP header when there is a delivery error.
output example:
Packet len=984 pt=100 seq=47914 ts=1532364329 ssrc=0xdeadbef0
==========
to
==========
replay: output rtp header elements for errors
outputs various elements of the RTP header when there is a delivery error.
output example:
Packet len=984 pt=100 seq=47914 ts=1532364329 ssrc=0xdeadbef0
BUG=webrtc:6991
==========
added bug=
The CQ bit was checked by philipp.hancke@googlemail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by philipp.hancke@googlemail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485435100975090,
"parent_rev": "09d6ef00fc21b9f2c2c27e50e5e2952329ac4b4b", "commit_rev":
"7b589600324ee7bc9a5b025482f6bc0c547ed24d"}
Message was sent while issue was closed.
Description was changed from
==========
replay: output rtp header elements for errors
outputs various elements of the RTP header when there is a delivery error.
output example:
Packet len=984 pt=100 seq=47914 ts=1532364329 ssrc=0xdeadbef0
BUG=webrtc:6991
==========
to
==========
replay: output rtp header elements for errors
outputs various elements of the RTP header when there is a delivery error.
output example:
Packet len=984 pt=100 seq=47914 ts=1532364329 ssrc=0xdeadbef0
BUG=webrtc:6991
Review-Url: https://codereview.webrtc.org/2621163006
Cr-Commit-Position: refs/heads/master@{#16294}
Committed:
https://chromium.googlesource.com/external/webrtc/+/7b589600324ee7bc9a5b02548...
==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/7b589600324ee7bc9a5b02548... |
