Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2620243003: Removes FATAL() from MicrophoneVolumeIsAvailable() on Android (Closed)

Created:
3 years, 11 months ago by henrika_webrtc
Modified:
3 years, 11 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removes FATAL() from MicrophoneVolumeIsAvailable() on Android. Trivial change that allows users to call MicrophoneVolumeIsAvailable() (and get a valid result) on Android without crashing. Special thanks to Stephane van Hardeveld (hardeves@gmail.com) who pointed out this issue. TBR=henrik.lundin BUG=NONE Review-Url: https://codereview.webrtc.org/2620243003 Cr-Commit-Position: refs/heads/master@{#16013} Committed: https://chromium.googlesource.com/external/webrtc/+/e8084706c34161bbdb72040aa8e398ef86c17e5a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M webrtc/modules/audio_device/android/audio_device_template.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
henrika_webrtc
PTAL
3 years, 11 months ago (2017-01-11 15:46:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2620243003/1
3 years, 11 months ago (2017-01-11 15:48:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/e8084706c34161bbdb72040aa8e398ef86c17e5a
3 years, 11 months ago (2017-01-11 16:59:29 UTC) #10
hlundin-webrtc
3 years, 11 months ago (2017-01-12 08:08:51 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698