Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Issue 2619353007: RTCRTPStreamStats.mediaTrackId renamed to trackId. (Closed)

Created:
3 years, 11 months ago by hbos
Modified:
3 years, 10 months ago
Reviewers:
hta-webrtc
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

RTCRTPStreamStats.mediaTrackId renamed to trackId. According to spec change: https://github.com/w3c/webrtc-stats/pull/142 BUG=webrtc:7064, chromium:685655 Review-Url: https://codereview.webrtc.org/2619353007 Cr-Commit-Position: refs/heads/master@{#16326} Committed: https://chromium.googlesource.com/external/webrtc/+/b0ae920faddfed0613700e9b16d32a0f0e7e18e1

Patch Set 1 #

Patch Set 2 : Rebase with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M webrtc/api/stats/rtcstats_objects.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/rtcstats_integrationtest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/rtcstatscollector.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/pc/rtcstatscollector_unittest.cc View 1 8 chunks +8 lines, -8 lines 0 comments Download
M webrtc/stats/rtcstats_objects.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
hbos
Please take a look, hta.
3 years, 11 months ago (2017-01-10 15:45:41 UTC) #4
hta-webrtc
Don't merge this until I have a PR....
3 years, 11 months ago (2017-01-11 12:38:37 UTC) #7
hbos
Will this happen before the cut? That would be good.
3 years, 11 months ago (2017-01-16 12:00:47 UTC) #8
hta-webrtc
lgtm
3 years, 10 months ago (2017-01-27 13:23:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2619353007/20001
3 years, 10 months ago (2017-01-27 13:31:55 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 14:35:20 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/b0ae920faddfed0613700e9b1...

Powered by Google App Engine
This is Rietveld 408576698