Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
3 years, 11 months ago by brandtr Modified:
3 years, 11 months ago Reviewers:
magjed_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionReorder assignments in WebRtcVideoChannel2::ConfigureReceiverRtp to match definition in VideoReceiveStream::Config.
No functional changes are intended by this CL.
BUG=None
Review-Url: https://codereview.webrtc.org/2617373002
Cr-Commit-Position: refs/heads/master@{#15989}
Committed: https://chromium.googlesource.com/external/webrtc/+/11273f1e00f053cab875b6063410fe58a0b6b160
Patch Set 1 #
Total comments: 1
Created: 3 years, 11 months ago
Messages
Total messages: 19 (12 generated)
Patchset #1 (id:1) has been deleted
brandtr@webrtc.org changed reviewers: + magjed@google.com
Just to tidy a bit. https://codereview.webrtc.org/2617373002/diff/20001/webrtc/media/engine/webrt... File webrtc/media/engine/webrtcvideoengine2.cc (right): https://codereview.webrtc.org/2617373002/diff/20001/webrtc/media/engine/webrt... webrtc/media/engine/webrtcvideoengine2.cc:1237: flexfec_config->flexfec_ssrc = flexfec_ssrc; In another CL (https://codereview.webrtc.org/2589713003), |flexfec_config| is folded into |config|. Hence it's placement here.
Description was changed from ========== Reorder assignments in WebRtcVideoChannel2::ConfigureReceiverRtp to match definition in VideoReceiveStream::Config. BUG=None ========== to ========== Reorder assignments in WebRtcVideoChannel2::ConfigureReceiverRtp to match definition in VideoReceiveStream::Config. BUG=None ==========
brandtr@webrtc.org changed reviewers: + magjed@webrtc.org - magjed@google.com
On 2017/01/09 11:45:28, brandtr wrote: > Just to tidy a bit. > > https://codereview.webrtc.org/2617373002/diff/20001/webrtc/media/engine/webrt... > File webrtc/media/engine/webrtcvideoengine2.cc (right): > > https://codereview.webrtc.org/2617373002/diff/20001/webrtc/media/engine/webrt... > webrtc/media/engine/webrtcvideoengine2.cc:1237: flexfec_config->flexfec_ssrc = > flexfec_ssrc; > In another CL (https://codereview.webrtc.org/2589713003), |flexfec_config| is > folded into |config|. Hence it's placement here. Sent to wrong review account.
So there is no functional change in this CL? It's hard to tell, but in that case it lgtm.
Description was changed from ========== Reorder assignments in WebRtcVideoChannel2::ConfigureReceiverRtp to match definition in VideoReceiveStream::Config. BUG=None ========== to ========== Reorder assignments in WebRtcVideoChannel2::ConfigureReceiverRtp to match definition in VideoReceiveStream::Config. No functional changes are intended by this CL. BUG=None ==========
On 2017/01/10 10:51:10, magjed_webrtc wrote: > So there is no functional change in this CL? It's hard to tell, but in that case > it lgtm. No functional changes are intended, sorry for not being clear about that before. I checked the code again, and I'm pretty certain this change will not have any unintended consequences.
The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
On 2017/01/10 12:10:12, brandtr wrote: > On 2017/01/10 10:51:10, magjed_webrtc wrote: > > So there is no functional change in this CL? It's hard to tell, but in that > case > > it lgtm. > > No functional changes are intended, sorry for not being clear about that before. > I checked the code again, and I'm pretty certain this change will not have any > unintended consequences. Thanks for clarifying. Still lgtm.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by brandtr@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484054150071010,
"parent_rev": "e996a997216789a697daf87f929f9dcc86663e3e", "commit_rev":
"11273f1e00f053cab875b6063410fe58a0b6b160"}
Message was sent while issue was closed.
Description was changed from ========== Reorder assignments in WebRtcVideoChannel2::ConfigureReceiverRtp to match definition in VideoReceiveStream::Config. No functional changes are intended by this CL. BUG=None ========== to ========== Reorder assignments in WebRtcVideoChannel2::ConfigureReceiverRtp to match definition in VideoReceiveStream::Config. No functional changes are intended by this CL. BUG=None Review-Url: https://codereview.webrtc.org/2617373002 Cr-Commit-Position: refs/heads/master@{#15989} Committed: https://chromium.googlesource.com/external/webrtc/+/11273f1e00f053cab875b6063... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/11273f1e00f053cab875b6063... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
