Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2615983002: Remove AudioClassifier (Closed)

Created:
3 years, 11 months ago by flim-webrtc
Modified:
3 years, 11 months ago
Reviewers:
minyue-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove AudioClassifier BUG=webrtc:5676 Review-Url: https://codereview.webrtc.org/2615983002 Cr-Commit-Position: refs/heads/master@{#15933} Committed: https://chromium.googlesource.com/external/webrtc/+/de770dd7e9c7a22c4ebb002f0fb6336e2ed83175

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -349 lines) Patch
M webrtc/modules/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 5 chunks +0 lines, -25 lines 0 comments Download
D webrtc/modules/audio_coding/neteq/audio_classifier.h View 1 chunk +0 lines, -58 lines 0 comments Download
D webrtc/modules/audio_coding/neteq/audio_classifier.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D webrtc/modules/audio_coding/neteq/audio_classifier_unittest.cc View 1 chunk +0 lines, -82 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/include/neteq.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq.cc View 1 chunk +1 line, -2 lines 0 comments Download
D webrtc/modules/audio_coding/neteq/test/audio_classifier_test.cc View 1 chunk +0 lines, -104 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
flim-webrtc
Hi Minyue, could you PTAL at this? Thanks!
3 years, 11 months ago (2017-01-05 23:39:02 UTC) #4
minyue-webrtc
lgtm nice to see this! great work!
3 years, 11 months ago (2017-01-06 15:57:14 UTC) #7
flim-webrtc
On 2017/01/06 15:57:14, minyue-webrtc wrote: > lgtm > > nice to see this! great work! ...
3 years, 11 months ago (2017-01-06 17:47:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2615983002/1
3 years, 11 months ago (2017-01-06 17:47:31 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 17:49:52 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/de770dd7e9c7a22c4ebb002f0...

Powered by Google App Engine
This is Rietveld 408576698