GN: Refactor webrtc_nonparallel_tests and audio_tests to avoid crossing package boundaries.

GN: Refactor webrtc_nonparallel_tests and audio_tests to avoid crossing package boundaries.

BUG=webrtc:6954
R=kjellander@webrtc.org

Review-Url: https://codereview.webrtc.org/2614833004
Cr-Commit-Position: refs/heads/master@{#15917}
Committed: https://chromium.googlesource.com/external/webrtc/+/894c2bb7b939b011cf1fa08b953ca294d845d7c7

[kjellander_webrtc, 2017-01-05 11:26:30]

lgtm

https://codereview.webrtc.org/2614833004/diff/1/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/2614833004/diff/1/webrtc/base/BUILD.gn#newcode756
webrtc/base/BUILD.gn:756: rtc_source_set("base_nonparallel_tests") {
Let's rename these to use rtc_base as prefix everywhere (one could argue base is
a better name though)

https://codereview.webrtc.org/2614833004/diff/1/webrtc/base/BUILD.gn#newcode756
webrtc/base/BUILD.gn:756: rtc_source_set("base_nonparallel_tests") {
I assume everything else is just moved code except this new target?

[kjellander_webrtc, 2017-01-05 11:26:53]

Please run trybots before review. Then we can catch simple things ahead of
review time.

[ehmaldonado_webrtc, 2017-01-05 11:46:18]

Patchset #2 (id:20001) has been deleted

[ehmaldonado_webrtc, 2017-01-05 12:30:23]

Still lgtm?

https://codereview.webrtc.org/2614833004/diff/1/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/2614833004/diff/1/webrtc/base/BUILD.gn#newcode756
webrtc/base/BUILD.gn:756: rtc_source_set("base_nonparallel_tests") {
On 2017/01/05 11:26:30, kjellander_webrtc wrote:
> I assume everything else is just moved code except this new target?

Yeah, I wanted to put everything under a single rtc_include_tests condition

[kjellander_webrtc, 2017-01-05 12:49:08]

lgtm

[ehmaldonado_webrtc, 2017-01-05 12:51:19]

The CQ bit was checked by ehmaldonado@webrtc.org

[commit-bot: I haz the power, 2017-01-05 12:51:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-05 14:03:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483620679378960,
"parent_rev": "5fbcd228f0781526ce2cbafba0a1f39f481ad81b", "commit_rev":
"894c2bb7b939b011cf1fa08b953ca294d845d7c7"}

[commit-bot: I haz the power, 2017-01-05 14:03:27]

Description was changed from

==========
GN: Refactor webrtc_nonparallel_tests and audio_tests to avoid crossing package
boundaries.

BUG=webrtc:6954
R=kjellander@webrtc.org
==========

to

==========
GN: Refactor webrtc_nonparallel_tests and audio_tests to avoid crossing package
boundaries.

BUG=webrtc:6954
R=kjellander@webrtc.org

Review-Url: https://codereview.webrtc.org/2614833004
Cr-Commit-Position: refs/heads/master@{#15917}
Committed:
https://chromium.googlesource.com/external/webrtc/+/894c2bb7b939b011cf1fa08b9...
==========

[commit-bot: I haz the power, 2017-01-05 14:03:28]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/894c2bb7b939b011cf1fa08b9...