Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2613713002: delete redundant members in ViEEncoder (Closed)

Created:
3 years, 11 months ago by kthelgason
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

delete redundant members in ViEEncoder This information is already available in another member, and storing it in more places only creates more opportunities for bugs. BUG=None Review-Url: https://codereview.webrtc.org/2613713002 Cr-Commit-Position: refs/heads/master@{#16094} Committed: https://chromium.googlesource.com/external/webrtc/+/93f16d74fc1249d574ae3504945985970a10975c

Patch Set 1 #

Patch Set 2 : fix oops #

Patch Set 3 : check for last_frame_info #

Total comments: 1

Patch Set 4 : add const #

Total comments: 1

Patch Set 5 : fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M webrtc/video/vie_encoder.h View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 1 2 3 4 5 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 24 (15 generated)
kthelgason
Please take a look when you have time. A small cleanup.
3 years, 11 months ago (2017-01-10 09:17:43 UTC) #6
perkj_webrtc
lgtm https://codereview.webrtc.org/2613713002/diff/10003/webrtc/video/vie_encoder.h File webrtc/video/vie_encoder.h (right): https://codereview.webrtc.org/2613713002/diff/10003/webrtc/video/vie_encoder.h#newcode145 webrtc/video/vie_encoder.h:145: int GetPixelCount() { return width * height; } ...
3 years, 11 months ago (2017-01-11 08:32:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2613713002/50001
3 years, 11 months ago (2017-01-11 09:07:11 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/12078)
3 years, 11 months ago (2017-01-11 09:11:05 UTC) #12
kthelgason
+stefan for owner LGTM
3 years, 11 months ago (2017-01-11 10:49:28 UTC) #14
kthelgason
+sprang@ for owner lgtm
3 years, 11 months ago (2017-01-16 10:08:37 UTC) #17
sprang_webrtc
lgtm with nit https://codereview.webrtc.org/2613713002/diff/50001/webrtc/video/vie_encoder.h File webrtc/video/vie_encoder.h (right): https://codereview.webrtc.org/2613713002/diff/50001/webrtc/video/vie_encoder.h#newcode145 webrtc/video/vie_encoder.h:145: int GetPixelCount() const { return width ...
3 years, 11 months ago (2017-01-16 10:12:19 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2613713002/70001
3 years, 11 months ago (2017-01-16 12:32:48 UTC) #21
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 14:15:27 UTC) #24
Message was sent while issue was closed.
Committed patchset #5 (id:70001) as
https://chromium.googlesource.com/external/webrtc/+/93f16d74fc1249d574ae35049...

Powered by Google App Engine
This is Rietveld 408576698