Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 2613443002: EndToEndTest.ReceivesAndRetransmitsNack now handles reordering. (Closed)

Created:
3 years, 11 months ago by philipel
Modified:
3 years, 11 months ago
Reviewers:
stefan-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

EndToEndTest.ReceivesAndRetransmitsNack now handles reordering. Since packets can be received out of order NACKs could be triggered before any packet was actually dropped. This cause the test to never drop packets which in turn caused the block of code which set the |observation_complete_| event to never execute. BUG=webrtc:2845 Review-Url: https://codereview.webrtc.org/2613443002 Cr-Commit-Position: refs/heads/master@{#15990} Committed: https://chromium.googlesource.com/external/webrtc/+/8054c7ecf890fc78c7a36032292d8a974c7dfb90

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M webrtc/video/end_to_end_tests.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
philipel
3 years, 11 months ago (2017-01-03 13:51:24 UTC) #2
philipel
3 years, 11 months ago (2017-01-09 13:53:11 UTC) #8
stefan-webrtc
lgtm
3 years, 11 months ago (2017-01-10 12:14:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2613443002/1
3 years, 11 months ago (2017-01-10 12:14:31 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 13:19:24 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/8054c7ecf890fc78c7a360322...

Powered by Google App Engine
This is Rietveld 408576698