Refactor rtc_unittests into several targets.

Refactor rtc_unittests into several targets.

Also fix some warnings.

NOTRY=True
BUG=webrtc:6954
Review-Url: https://codereview.webrtc.org/2611663002
Cr-Commit-Position: refs/heads/master@{#15900}
Committed: https://chromium.googlesource.com/external/webrtc/+/da8dcfb43e88719652ebe7c84107015a932b6ce5

[ehmaldonado_webrtc, 2017-01-03 14:23:36]

Patchset #1 (id:1) has been deleted

[ehmaldonado_webrtc, 2017-01-03 14:25:01]

Description was changed from

==========
stuff

BUG=
==========

to

==========
Refactor rtc_unittests into several targets.

Fix some warnings.


BUG=
==========

[ehmaldonado_webrtc, 2017-01-03 16:04:30]

Patchset #3 (id:60001) has been deleted

[ehmaldonado_webrtc, 2017-01-03 16:04:36]

Patchset #2 (id:40001) has been deleted

[ehmaldonado_webrtc, 2017-01-03 16:04:51]

The CQ bit was checked by ehmaldonado@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 16:04:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-03 16:06:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 16:06:44]

Dry run: Try jobs failed on following builders:
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/16165)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/21402)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/20140)
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/17488)
  mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)

[ehmaldonado_webrtc, 2017-01-03 16:34:28]

Patchset #3 (id:100001) has been deleted

[ehmaldonado_webrtc, 2017-01-03 16:38:54]

Patchset #3 (id:120001) has been deleted

[ehmaldonado_webrtc, 2017-01-03 17:17:43]

Patchset #4 (id:160001) has been deleted

[ehmaldonado_webrtc, 2017-01-03 17:17:51]

Patchset #3 (id:140001) has been deleted

[ehmaldonado_webrtc, 2017-01-03 17:18:12]

Patchset #1 (id:20001) has been deleted

[ehmaldonado_webrtc, 2017-01-03 17:44:54]

Patchset #2 (id:80002) has been deleted

[ehmaldonado_webrtc, 2017-01-03 18:08:56]

Patchset #4 (id:230001) has been deleted

[ehmaldonado_webrtc, 2017-01-03 18:09:05]

Patchset #3 (id:210001) has been deleted

[ehmaldonado_webrtc, 2017-01-03 18:09:06]

Patchset #2 (id:190001) has been deleted

[ehmaldonado_webrtc, 2017-01-03 18:32:51]

The CQ bit was checked by ehmaldonado@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 18:32:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-03 18:37:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 18:37:06]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/11883)

[ehmaldonado_webrtc, 2017-01-03 18:41:49]

Patchset #2 (id:250001) has been deleted

[ehmaldonado_webrtc, 2017-01-03 18:58:32]

ehmaldonado@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[ehmaldonado_webrtc, 2017-01-03 18:58:33]

Should we create a bug for this, and the other refactor CLs?

[ehmaldonado_webrtc, 2017-01-04 12:08:02]

Description was changed from

==========
Refactor rtc_unittests into several targets.

Fix some warnings.


BUG=
==========

to

==========
Refactor rtc_unittests into several targets.

Also fix some warnings.


BUG=webrtc:6954
==========

[ehmaldonado_webrtc, 2017-01-04 12:39:39]

Patchset #3 (id:290001) has been deleted

[kjellander_webrtc, 2017-01-04 12:41:44]

On 2017/01/03 18:58:33, ehmaldonado_webrtc wrote:
> Should we create a bug for this, and the other refactor CLs?

I see you already did. Since you're currently working on this I will hold off my
review (please don't delete patch sets after sending out for review, since my
pending comments may be lost).

[ehmaldonado_webrtc, 2017-01-04 13:27:59]

Patchset #5 (id:350001) has been deleted

[ehmaldonado_webrtc, 2017-01-04 13:35:40]

Patchset #4 (id:330001) has been deleted

[ehmaldonado_webrtc, 2017-01-04 13:39:09]

Patchset #4 (id:370001) has been deleted

[kjellander_webrtc, 2017-01-04 14:06:28]

lgtm with nit fixed.

I think you might want to run all trybots here, it's a lot of changes.

https://codereview.webrtc.org/2611663002/diff/310001/webrtc/sdk/BUILD.gn
File webrtc/sdk/BUILD.gn (right):

https://codereview.webrtc.org/2611663002/diff/310001/webrtc/sdk/BUILD.gn#newc...
webrtc/sdk/BUILD.gn:234:
rtc_static_library("rtc_sdk_peerconnection_objc_unittests") {
rtc_source_set?

[kjellander_webrtc, 2017-01-04 14:06:44]

On 2017/01/04 14:06:28, kjellander_webrtc wrote:
> lgtm with nit fixed.
> 
> I think you might want to run all trybots here, it's a lot of changes.
> 
> https://codereview.webrtc.org/2611663002/diff/310001/webrtc/sdk/BUILD.gn
> File webrtc/sdk/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/2611663002/diff/310001/webrtc/sdk/BUILD.gn#newc...
> webrtc/sdk/BUILD.gn:234:
> rtc_static_library("rtc_sdk_peerconnection_objc_unittests") {
> rtc_source_set?

Also, you'll need code owner approval for the .cc changes.

[ehmaldonado_webrtc, 2017-01-04 14:20:14]

The CQ bit was checked by ehmaldonado@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 14:20:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[ehmaldonado_webrtc, 2017-01-04 14:20:49]

ehmaldonado@webrtc.org changed reviewers:
+ henrika@webrtc.org

[ehmaldonado_webrtc, 2017-01-04 14:20:49]

henrika, can you review please?

[henrika_webrtc, 2017-01-04 14:43:15]

Don't know the tests as such but can't find any functional changes but the style
and build changes look OK.

LGTM

[ehmaldonado_webrtc, 2017-01-04 14:57:11]

Description was changed from

==========
Refactor rtc_unittests into several targets.

Also fix some warnings.


BUG=webrtc:6954
==========

to

==========
Refactor rtc_unittests into several targets.

Also fix some warnings.

NOTRY=True
BUG=webrtc:6954
==========

[commit-bot: I haz the power, 2017-01-04 15:01:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 15:01:59]

Dry run: This issue passed the CQ dry run.

[ehmaldonado_webrtc, 2017-01-04 15:09:02]

The CQ bit was checked by ehmaldonado@webrtc.org

[ehmaldonado_webrtc, 2017-01-04 15:09:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2611663002/#ps410001 (title:
"Nit.")

[commit-bot: I haz the power, 2017-01-04 15:09:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-04 15:11:23]

CQ is committing da patch.

Bot data: {"patchset_id": 410001, "attempt_start_ts": 1483542542090020,
"parent_rev": "fd58b6106840c77538e864a22db68f6a8e28d848", "commit_rev":
"da8dcfb43e88719652ebe7c84107015a932b6ce5"}

[commit-bot: I haz the power, 2017-01-04 15:11:26]

Description was changed from

==========
Refactor rtc_unittests into several targets.

Also fix some warnings.

NOTRY=True
BUG=webrtc:6954
==========

to

==========
Refactor rtc_unittests into several targets.

Also fix some warnings.

NOTRY=True
BUG=webrtc:6954

Review-Url: https://codereview.webrtc.org/2611663002
Cr-Commit-Position: refs/heads/master@{#15900}
Committed:
https://chromium.googlesource.com/external/webrtc/+/da8dcfb43e88719652ebe7c84...
==========

[commit-bot: I haz the power, 2017-01-04 15:11:27]

Committed patchset #5 (id:410001) as
https://chromium.googlesource.com/external/webrtc/+/da8dcfb43e88719652ebe7c84...