Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2611113003:
AVFoundationVideoCapturer: Fix apply_rotation() logic (Closed)
|
Created:
3 years, 11 months ago by magjed_webrtc Modified:
3 years, 11 months ago Reviewers:
kthelgason CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAVFoundationVideoCapturer: Fix apply_rotation() logic
When apply_rotation() returns true, rotation and captured width/heigh are not set correctly.
BUG=webrtc:6925
Review-Url: https://codereview.webrtc.org/2611113003
Cr-Commit-Position: refs/heads/master@{#15963}
Committed: https://chromium.googlesource.com/external/webrtc/+/0b7bd756593105b2aa198bdcf03dea7c0f2a884a
Patch Set 1 #
Total comments: 2
Messages
Total messages: 18 (11 generated)
The CQ bit was checked by magjed@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== AVFoundationVideoCapturer: Fix apply_rotation() logic BUG=webrtc:6925 ========== to ========== AVFoundationVideoCapturer: Fix apply_rotation() logic When apply_rotation() returns true, rotation and captured width/heigh are not set correctly. BUG=webrtc:6925 ==========
magjed@webrtc.org changed reviewers: + kthelgason@webrtc.org
Kári - please take a look.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm % comment https://codereview.webrtc.org/2611113003/diff/1/webrtc/sdk/objc/Framework/Cla... File webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm (right): https://codereview.webrtc.org/2611113003/diff/1/webrtc/sdk/objc/Framework/Cla... webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm:165: if (rotation == kVideoRotation_0 || rotation == kVideoRotation_180) { The first case can never happen due to the outer conditional
https://codereview.webrtc.org/2611113003/diff/1/webrtc/sdk/objc/Framework/Cla... File webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm (right): https://codereview.webrtc.org/2611113003/diff/1/webrtc/sdk/objc/Framework/Cla... webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm:165: if (rotation == kVideoRotation_0 || rotation == kVideoRotation_180) { On 2017/01/09 08:18:28, kthelgason wrote: > The first case can never happen due to the outer conditional Right, and the previous code just did (rotation == kVideoRotation_180), but I think it's slightly clearer and more future proof to include the kVideoRotation_0 case.
The CQ bit was checked by magjed@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/11979)
The CQ bit was checked by magjed@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1483974397439230, "parent_rev":
"075c6d7f7ed6586f7ccdf5c3eed77b0b0afdd434", "commit_rev":
"0b7bd756593105b2aa198bdcf03dea7c0f2a884a"}
Message was sent while issue was closed.
Description was changed from ========== AVFoundationVideoCapturer: Fix apply_rotation() logic When apply_rotation() returns true, rotation and captured width/heigh are not set correctly. BUG=webrtc:6925 ========== to ========== AVFoundationVideoCapturer: Fix apply_rotation() logic When apply_rotation() returns true, rotation and captured width/heigh are not set correctly. BUG=webrtc:6925 Review-Url: https://codereview.webrtc.org/2611113003 Cr-Commit-Position: refs/heads/master@{#15963} Committed: https://chromium.googlesource.com/external/webrtc/+/0b7bd756593105b2aa198bdcf... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/0b7bd756593105b2aa198bdcf... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
