Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2610873002: Temporarily remove SSRC DCHECK in RTPSender::SendToNetwork. (Closed)

Created:
3 years, 11 months ago by brandtr
Modified:
3 years, 11 months ago
Reviewers:
danilchap
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Temporarily remove SSRC DCHECK in RTPSender::SendToNetwork. Removing the DCHECK due to (sometimes) failing voe_auto_test. Long-term, this DCHECK should be readded. Before that can happen, the SSRC in the RTPSender should be made immutable. TESTED=No failures when running third_party/gtest-parallel/gtest-parallel --repeat=5000 --gtest_filter="VolumeTest.ManualInputMutingMutesMicrophone" out/Debug/voe_auto_test. BUG=webrtc:6887 Review-Url: https://codereview.webrtc.org/2610873002 Cr-Commit-Position: refs/heads/master@{#15962} Committed: https://chromium.googlesource.com/external/webrtc/+/075c6d7f7ed6586f7ccdf5c3eed77b0b0afdd434

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase. #

Patch Set 3 : Remove DCHECK without adding clause to conditional. #

Total comments: 2

Patch Set 4 : danilchap comments 1. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 27 (15 generated)
brandtr
3 years, 11 months ago (2017-01-04 16:03:11 UTC) #5
danilchap
DCHECK is there because of assumption ssrc will not change once packets start to fly. ...
3 years, 11 months ago (2017-01-04 16:39:04 UTC) #8
brandtr
On 2017/01/04 16:39:04, danilchap wrote: > DCHECK is there because of assumption ssrc will not ...
3 years, 11 months ago (2017-01-04 16:53:02 UTC) #9
danilchap
https://codereview.webrtc.org/2610873002/diff/1/webrtc/modules/rtp_rtcp/source/rtp_sender.cc File webrtc/modules/rtp_rtcp/source/rtp_sender.cc (right): https://codereview.webrtc.org/2610873002/diff/1/webrtc/modules/rtp_rtcp/source/rtp_sender.cc#newcode884 webrtc/modules/rtp_rtcp/source/rtp_sender.cc:884: if (storage == kAllowRetransmission && ssrc == SSRC()) { ...
3 years, 11 months ago (2017-01-05 12:23:36 UTC) #10
brandtr
Rebase.
3 years, 11 months ago (2017-01-09 07:58:50 UTC) #11
brandtr
> This happens in particular in the voe_auto_test suite, where my feeling is that > ...
3 years, 11 months ago (2017-01-09 08:45:51 UTC) #12
brandtr
On 2017/01/09 08:45:51, brandtr wrote: > > This happens in particular in the voe_auto_test suite, ...
3 years, 11 months ago (2017-01-09 08:52:21 UTC) #13
brandtr
As discussed.
3 years, 11 months ago (2017-01-09 12:00:19 UTC) #15
danilchap
lgtm https://codereview.webrtc.org/2610873002/diff/40001/webrtc/modules/rtp_rtcp/source/rtp_sender.cc File webrtc/modules/rtp_rtcp/source/rtp_sender.cc (right): https://codereview.webrtc.org/2610873002/diff/40001/webrtc/modules/rtp_rtcp/source/rtp_sender.cc#newcode885 webrtc/modules/rtp_rtcp/source/rtp_sender.cc:885: // TODO(brandtr): Here we should RTC_DCHECK_EQ(ssrc, SSRC()), but ...
3 years, 11 months ago (2017-01-09 12:08:59 UTC) #16
brandtr
https://codereview.webrtc.org/2610873002/diff/40001/webrtc/modules/rtp_rtcp/source/rtp_sender.cc File webrtc/modules/rtp_rtcp/source/rtp_sender.cc (right): https://codereview.webrtc.org/2610873002/diff/40001/webrtc/modules/rtp_rtcp/source/rtp_sender.cc#newcode885 webrtc/modules/rtp_rtcp/source/rtp_sender.cc:885: // TODO(brandtr): Here we should RTC_DCHECK_EQ(ssrc, SSRC()), but that ...
3 years, 11 months ago (2017-01-09 12:16:08 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2610873002/60001
3 years, 11 months ago (2017-01-09 13:09:21 UTC) #24
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 13:11:16 UTC) #27
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/075c6d7f7ed6586f7ccdf5c3e...

Powered by Google App Engine
This is Rietveld 408576698