Create the MockIceTransport

Create the MockIceTransport

The src/remoting/protocol/channel_socket_adapter_unittest.cc will use this class
instead of creating its own MockTransportChannel which subclasses the TransportChannel.
This will make it easier to switch the base class of P2PTransportChannel from
TransportChannel to IceTransportInternal.

BUG=webrtc:6951
Review-Url: https://codereview.webrtc.org/2610663003
Cr-Commit-Position: refs/heads/master@{#15922}
Committed: https://chromium.googlesource.com/external/webrtc/+/1a619cdb5d742c8a0b535c74115411ea4c34e645

[Zhi Huang, 2017-01-04 00:00:37]

The CQ bit was checked by zhihuang@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 00:00:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-04 01:00:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 01:00:51]

Dry run: This issue passed the CQ dry run.

[Taylor Brandstetter, 2017-01-05 01:12:37]

Description was changed from

==========
Create the MockIceTransport

The src/remoting/protocol/channel_socket_adapter_unittest.cc will use this class
instead of creating its own MockTransportChannel which subclasses the
TransportChannel.
This will make it easier to switch the base class of P2PTransportChannel from
TransportChannl to IceTransportInternal.

BUG=webrtc::6951
==========

to

==========
Create the MockIceTransport

The src/remoting/protocol/channel_socket_adapter_unittest.cc will use this class
instead of creating its own MockTransportChannel which subclasses the
TransportChannel.
This will make it easier to switch the base class of P2PTransportChannel from
TransportChannel to IceTransportInternal.

BUG=webrtc:6951
==========

[Taylor Brandstetter, 2017-01-05 01:21:02]

deadbeef@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[Taylor Brandstetter, 2017-01-05 01:21:02]

lgtm. Though, have you tested that the follow-up CLs
(https://codereview.chromium.org/2613653002/ and
https://codereview.webrtc.org/2608353003/) build successfully with this?

[Zhi Huang, 2017-01-05 01:25:48]

On 2017/01/05 01:21:02, Taylor Brandstetter wrote:
> lgtm. Though, have you tested that the follow-up CLs
> (https://codereview.chromium.org/2613653002/ and
> https://codereview.webrtc.org/2608353003/) build successfully with this?

Yes, CL https://codereview.webrtc.org/2608353003/ is created based on this one
and it works in Chromium.

[Zhi Huang, 2017-01-05 18:41:52]

The CQ bit was checked by zhihuang@webrtc.org

[commit-bot: I haz the power, 2017-01-05 18:41:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-05 18:43:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 18:43:27]

Try jobs failed on following builders:
  ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/16208)
  ios_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/16064)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/21455)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/20184)

[Zhi Huang, 2017-01-05 19:08:38]

Patchset #2 (id:20001) has been deleted

[Zhi Huang, 2017-01-05 19:08:48]

The CQ bit was checked by zhihuang@webrtc.org

[Zhi Huang, 2017-01-05 19:08:48]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2610663003/#ps40001 (title:
"Merge")

[commit-bot: I haz the power, 2017-01-05 19:08:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-05 20:21:53]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483643328552440,
"parent_rev": "92190cb0520035f86723af4c44cb9f90c6f3ba71", "commit_rev":
"1a619cdb5d742c8a0b535c74115411ea4c34e645"}

[commit-bot: I haz the power, 2017-01-05 20:21:56]

Description was changed from

==========
Create the MockIceTransport

The src/remoting/protocol/channel_socket_adapter_unittest.cc will use this class
instead of creating its own MockTransportChannel which subclasses the
TransportChannel.
This will make it easier to switch the base class of P2PTransportChannel from
TransportChannel to IceTransportInternal.

BUG=webrtc:6951
==========

to

==========
Create the MockIceTransport

The src/remoting/protocol/channel_socket_adapter_unittest.cc will use this class
instead of creating its own MockTransportChannel which subclasses the
TransportChannel.
This will make it easier to switch the base class of P2PTransportChannel from
TransportChannel to IceTransportInternal.

BUG=webrtc:6951

Review-Url: https://codereview.webrtc.org/2610663003
Cr-Commit-Position: refs/heads/master@{#15922}
Committed:
https://chromium.googlesource.com/external/webrtc/+/1a619cdb5d742c8a0b535c741...
==========

[commit-bot: I haz the power, 2017-01-05 20:21:56]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/1a619cdb5d742c8a0b535c741...