Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2609863003: Relax parsing of a=bundle-only with a nonzero port. (Closed)

Created:
3 years, 11 months ago by Taylor Brandstetter
Modified:
3 years, 11 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Relax parsing of a=bundle-only with a nonzero port. This use of a=bundle-only is unspecified, but not disallowed, so it should simply result in the attribute being ignored, not a parse failure. Note that older versions of Firefox may generate SDP with a=bundle-only and a nonzero port, so this also fixes an interop issue. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1325991 BUG=webrtc:4674 Review-Url: https://codereview.webrtc.org/2609863003 Cr-Commit-Position: refs/heads/master@{#15890} Committed: https://chromium.googlesource.com/external/webrtc/+/12771a19103b8d8f037f67f41299a8256881764d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -13 lines) Patch
M webrtc/api/webrtcsdp.cc View 1 chunk +9 lines, -6 lines 0 comments Download
M webrtc/api/webrtcsdp_unittest.cc View 1 chunk +14 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Taylor Brandstetter
3 years, 11 months ago (2017-01-03 18:31:16 UTC) #2
pthatcher1
lgtm
3 years, 11 months ago (2017-01-03 18:41:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2609863003/1
3 years, 11 months ago (2017-01-03 20:46:30 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 21:53:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/12771a19103b8d8f037f67f41...

Powered by Google App Engine
This is Rietveld 408576698