Refactoring ./webrtc/modules/BUILD.gn for gn check

webrtc/modules/audio_coding/BUILD.gn

Index: webrtc/modules/audio_coding/BUILD.gn
diff --git a/webrtc/modules/audio_coding/BUILD.gn b/webrtc/modules/audio_coding/BUILD.gn
index 70ecc55dc2aa86d3f2739bdd6d91567fe112be17..c5635da1034a1ab08258443151b81559f5eb5da7 100644
--- a/webrtc/modules/audio_coding/BUILD.gn
+++ b/webrtc/modules/audio_coding/BUILD.gn
@@ -540,7 +540,30 @@ rtc_static_library("isac") {
 }
 
 rtc_static_library("isac_c") {
-  visibility = [ ":*" ]  # Only targets in this file can depend on this.
+  # Only targets in this file should depend on this (or testing targets).
+  visibility = [
+    "//webrtc/modules:_modules_unittests__library",
+    "//webrtc/modules:modules_tests",
+    "//webrtc/modules:modules_tests_arch_executable",
+    "//webrtc/modules:modules_unittests",
+    "//webrtc/modules:modules_unittests__test_runner_script",
+    "//webrtc/modules:modules_unittests__test_runner_script__write_deps",
+    "//webrtc/modules:modules_unittests_apk__create__package",
+    "//webrtc/modules:modules_unittests_apk__create__package_resources",
+    "//webrtc/modules:modules_unittests_apk__create_incremental__package",
+    "//webrtc/modules:modules_unittests_apk__create_incremental__package_resources",
+    "//webrtc/modules:modules_unittests_apk__create_incremental_generate_manifest",
+    "//webrtc/modules:modules_unittests_apk__java__compile_java__javac",
+    "//webrtc/modules:modules_unittests_apk__java__compile_java__process_prebuilt__assert",
+    "//webrtc/modules:modules_unittests_apk__java__compile_java__process_prebuilt__copy",
+    "//webrtc/modules:modules_unittests_apk__process_resources",
+    "//webrtc/modules:modules_unittests_arch_executable",
+    "//webrtc/modules:modules_unittests_arch_executable_sources",
+    "//webrtc/modules:modules_unittests_incremental__test_runner_script",
+    "//webrtc/modules:modules_unittests_incremental__test_runner_script__write_deps",
+    ":*",
+  ]
+
   sources = [
     "codecs/isac/main/include/audio_decoder_isac.h",
     "codecs/isac/main/include/audio_encoder_isac.h",
@@ -808,7 +831,27 @@ rtc_static_library("pcm16b") {
 }
 
 rtc_source_set("pcm16b_c") {
-  visibility = [ ":*" ]  # Only targets in this file can depend on this.
+  # Only targets in this file should depend on this (or testing targets).
+  visibility = [
+    "//webrtc/modules:_modules_tests__library",

[kjellander_webrtc, 2016/12/30 13:22:44]

Please make this //webrtc/modules:* instead.
All targets with __ are template-generated ones.
Keep ":*" though.

[mbonadei, 2016/12/30 13:36:10]

Acknowledged.

+    "//webrtc/modules:modules_tests",
+    "//webrtc/modules:modules_tests__test_runner_script",
+    "//webrtc/modules:modules_tests__test_runner_script__write_deps",
+    "//webrtc/modules:modules_tests_apk__create__package",
+    "//webrtc/modules:modules_tests_apk__create__package_resources",
+    "//webrtc/modules:modules_tests_apk__create_incremental__package",
+    "//webrtc/modules:modules_tests_apk__create_incremental__package_resources",
+    "//webrtc/modules:modules_tests_apk__create_incremental_generate_manifest",
+    "//webrtc/modules:modules_tests_apk__java__compile_java__javac",
+    "//webrtc/modules:modules_tests_apk__java__compile_java__process_prebuilt__assert",
+    "//webrtc/modules:modules_tests_apk__java__compile_java__process_prebuilt__copy",
+    "//webrtc/modules:modules_tests_apk__process_resources",
+    "//webrtc/modules:modules_tests_arch_executable",
+    "//webrtc/modules:modules_tests_arch_executable_sources",
+    "//webrtc/modules:modules_tests_incremental__test_runner_script",
+    "//webrtc/modules:modules_tests_incremental__test_runner_script__write_deps",
+    ":*",
+  ]
   sources = [
     "codecs/pcm16b/pcm16b.c",
     "codecs/pcm16b/pcm16b.h",