Refactoring ./webrtc/modules/BUILD.gn for gn check

webrtc/modules/audio_coding/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../../build/webrtc.gni")
 import("audio_coding.gni")
@@ skipping 522 matching lines @@
     ":audio_decoder_interface",
     ":audio_encoder_interface",
     ":isac_common",
   ]
   public_deps = [
     ":isac_c",
   ]
 }
 
 rtc_static_library("isac_c") {
-  visibility = [ ":*" ]  # Only targets in this file can depend on this.
+  # Only targets in this file should depend on this (or testing targets).
+  visibility = [
+    "//webrtc/modules:_modules_unittests__library",
+    "//webrtc/modules:modules_tests",
+    "//webrtc/modules:modules_tests_arch_executable",
+    "//webrtc/modules:modules_unittests",
+    "//webrtc/modules:modules_unittests__test_runner_script",
+    "//webrtc/modules:modules_unittests__test_runner_script__write_deps",
+    "//webrtc/modules:modules_unittests_apk__create__package",
+    "//webrtc/modules:modules_unittests_apk__create__package_resources",
+    "//webrtc/modules:modules_unittests_apk__create_incremental__package",
+    "//webrtc/modules:modules_unittests_apk__create_incremental__package_resources",
+    "//webrtc/modules:modules_unittests_apk__create_incremental_generate_manifest",
+    "//webrtc/modules:modules_unittests_apk__java__compile_java__javac",
+    "//webrtc/modules:modules_unittests_apk__java__compile_java__process_prebuilt__assert",
+    "//webrtc/modules:modules_unittests_apk__java__compile_java__process_prebuilt__copy",
+    "//webrtc/modules:modules_unittests_apk__process_resources",
+    "//webrtc/modules:modules_unittests_arch_executable",
+    "//webrtc/modules:modules_unittests_arch_executable_sources",
+    "//webrtc/modules:modules_unittests_incremental__test_runner_script",
+    "//webrtc/modules:modules_unittests_incremental__test_runner_script__write_deps",
+    ":*",
+  ]
+
   sources = [
     "codecs/isac/main/include/audio_decoder_isac.h",
     "codecs/isac/main/include/audio_encoder_isac.h",
     "codecs/isac/main/include/isac.h",
     "codecs/isac/main/source/arith_routines.c",
     "codecs/isac/main/source/arith_routines.h",
     "codecs/isac/main/source/arith_routines_hist.c",
     "codecs/isac/main/source/arith_routines_logist.c",
     "codecs/isac/main/source/bandwidth_estimator.c",
     "codecs/isac/main/source/bandwidth_estimator.h",
@@ skipping 247 matching lines @@
     "../..:webrtc_common",
     "../../base:rtc_base_approved",
   ]
   public_deps = [
     ":pcm16b_c",
   ]
   public_configs = [ ":pcm16b_config" ]
 }
 
 rtc_source_set("pcm16b_c") {
-  visibility = [ ":*" ]  # Only targets in this file can depend on this.
+  # Only targets in this file should depend on this (or testing targets).
+  visibility = [
+    "//webrtc/modules:_modules_tests__library",

[kjellander_webrtc, 2016/12/30 13:22:44]

Please make this //webrtc/modules:* instead.
All targets with __ are template-generated ones.
Keep ":*" though.

[mbonadei, 2016/12/30 13:36:10]

Acknowledged.

+    "//webrtc/modules:modules_tests",
+    "//webrtc/modules:modules_tests__test_runner_script",
+    "//webrtc/modules:modules_tests__test_runner_script__write_deps",
+    "//webrtc/modules:modules_tests_apk__create__package",
+    "//webrtc/modules:modules_tests_apk__create__package_resources",
+    "//webrtc/modules:modules_tests_apk__create_incremental__package",
+    "//webrtc/modules:modules_tests_apk__create_incremental__package_resources",
+    "//webrtc/modules:modules_tests_apk__create_incremental_generate_manifest",
+    "//webrtc/modules:modules_tests_apk__java__compile_java__javac",
+    "//webrtc/modules:modules_tests_apk__java__compile_java__process_prebuilt__assert",
+    "//webrtc/modules:modules_tests_apk__java__compile_java__process_prebuilt__copy",
+    "//webrtc/modules:modules_tests_apk__process_resources",
+    "//webrtc/modules:modules_tests_arch_executable",
+    "//webrtc/modules:modules_tests_arch_executable_sources",
+    "//webrtc/modules:modules_tests_incremental__test_runner_script",
+    "//webrtc/modules:modules_tests_incremental__test_runner_script__write_deps",
+    ":*",
+  ]
   sources = [
     "codecs/pcm16b/pcm16b.c",
     "codecs/pcm16b/pcm16b.h",
   ]
 
   public_configs = [ ":pcm16b_config" ]
   deps = [
     "../..:webrtc_common",
   ]
 }
@@ skipping 1093 matching lines @@
       "../../test:test_main",
       "//testing/gtest",
     ]
 
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
   }
 }