Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2608673002: Add rtc_enable_external_auth variable for setting ENABLE_EXTERNAL_AUTH (Closed)

Created:
3 years, 11 months ago by kjellander_webrtc
Modified:
3 years, 11 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add rtc_enable_external_auth variable for setting ENABLE_EXTERNAL_AUTH This will make it easier for some downstream projects to control whether or not to set ENABLE_EXTERNAL_AUTH, via the GN variable. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2608673002 Cr-Commit-Position: refs/heads/master@{#15894} Committed: https://chromium.googlesource.com/external/webrtc/+/e7b0f522d77799dceec400c0ecf5d6ce6121c62b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M webrtc/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M webrtc/build/webrtc.gni View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
kjellander_webrtc
3 years, 11 months ago (2016-12-29 06:02:07 UTC) #3
pthatcher1
lgtm
3 years, 11 months ago (2017-01-03 19:29:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2608673002/1
3 years, 11 months ago (2017-01-04 06:06:50 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 06:09:29 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/e7b0f522d77799dceec400c0e...

Powered by Google App Engine
This is Rietveld 408576698