Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2608353003: Make P2PTransportChannel inherit from IceTransportInternal. (Closed)

Created:
3 years, 11 months ago by Zhi Huang
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make P2PTransportChannel inherit from IceTransportInternal. Make P2PTransportChannel inherit from IceTransportInternal instead of TransportChannelImpl and TransportChannel, so that the DTLS-related methods can be separated from P2PTransportChannel. BUG=webrtc:6951 Review-Url: https://codereview.webrtc.org/2608353003 Cr-Commit-Position: refs/heads/master@{#16041} Committed: https://chromium.googlesource.com/external/webrtc/+/d06adf60c110b51974a6b7a587297559ef77b6ee

Patch Set 1 #

Patch Set 2 : Modified MockIceTransport #

Total comments: 1

Patch Set 3 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+451 lines, -232 lines) Patch
M webrtc/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.h View 7 chunks +16 lines, -17 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.cc View 1 2 4 chunks +11 lines, -12 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M webrtc/p2p/base/faketransportcontroller.h View 6 chunks +233 lines, -11 lines 0 comments Download
M webrtc/p2p/base/icetransportinternal.h View 1 5 chunks +22 lines, -16 lines 0 comments Download
M webrtc/p2p/base/jseptransport.h View 2 chunks +4 lines, -6 lines 0 comments Download
M webrtc/p2p/base/mockicetransport.h View 1 2 2 chunks +29 lines, -21 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.h View 8 chunks +29 lines, -58 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 1 2 7 chunks +47 lines, -20 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 21 chunks +31 lines, -28 lines 0 comments Download
M webrtc/p2p/base/transportchannel.h View 1 3 chunks +9 lines, -16 lines 0 comments Download
M webrtc/p2p/base/transportchannelimpl.h View 1 2 2 chunks +1 line, -6 lines 0 comments Download
M webrtc/p2p/base/transportcontroller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/transportcontroller.cc View 1 2 6 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 17 (14 generated)
Taylor Brandstetter
lgtm. Which CL do you plan to land first, though? This or the DTLS one ...
3 years, 11 months ago (2017-01-10 17:49:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2608353003/60001
3 years, 11 months ago (2017-01-12 23:55:55 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 23:58:36 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/d06adf60c110b51974a6b7a58...

Powered by Google App Engine
This is Rietveld 408576698