Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2608233002: Reland of Added first layer of the echo canceller 3 functionality. (Closed)

Created:
3 years, 11 months ago by peah-webrtc
Modified:
3 years, 11 months ago
Reviewers:
ivoc, aleloi, hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Added first layer of the echo canceller 3 functionality. Reason for reland: Added disabling of the BlockProcessor DEATH tests due to false alarms on the trybots. These errors cannot be reproduced locally and they occur only in the DEATH test code, which means that the memory leaks do not occur under normal conditions. Original issue's description: > Reason for revert: > Memcheck buildbot detected memory leaks in the death tests. The code looks fine > to me, but please investigate what causes the error and reland. > > Original issue's description: > > Added first layer of the echo canceller 3 functionality. > > > > This CL adds the first layer of the echo canceller 3. > > All of the code is as it should, apart from > > block_processor.* which only contains placeholder > > functionality. (Upcoming CLs will add proper > > functionality into those files.) > > > > > > > > BUG=webrtc:6018 > > > > Review-Url: https://codereview.webrtc.org/2584493002 > > Cr-Commit-Position: refs/heads/master@{#15861} > > Committed: > https://chromium.googlesource.com/external/webrtc/+/38fd1758e90bcdc7690a552e7ef0ec0d143d2f30 > > TBR=ivoc@webrtc.org,aleloi@webrtc.org,henrik.lundin@webrtc.org,peah@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6018 BUG=webrtc:6018 TBR=ivoc@webrtc.org,aleloi@webrtc.org,henrik.lundin@webrtc.org Review-Url: https://codereview.webrtc.org/2608233002 Cr-Commit-Position: refs/heads/master@{#15884} Committed: https://chromium.googlesource.com/external/webrtc/+/d0263544107b4e76de0d4b4d05f4c77d5739e2c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2524 lines, -15 lines) Patch
M webrtc/modules/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/aec3/aec3_constants.h View 1 chunk +52 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/aec3/block_framer.h View 1 chunk +47 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/aec3/block_framer.cc View 1 chunk +59 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/aec3/block_framer_unittest.cc View 1 chunk +261 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/aec3/block_processor.h View 1 chunk +44 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/aec3/block_processor.cc View 1 chunk +73 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/aec3/block_processor_unittest.cc View 1 chunk +143 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/aec3/cascaded_biquad_filter.h View 1 chunk +58 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/aec3/cascaded_biquad_filter.cc View 1 chunk +58 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/aec3/cascaded_biquad_filter_unittest.cc View 1 chunk +98 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/echo_canceller3.h View 3 chunks +89 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/echo_canceller3.cc View 2 chunks +312 lines, -11 lines 0 comments Download
A webrtc/modules/audio_processing/aec3/echo_canceller3_unittest.cc View 1 chunk +717 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/aec3/frame_blocker.h View 1 chunk +48 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/aec3/frame_blocker.cc View 1 chunk +72 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/aec3/frame_blocker_unittest.cc View 1 chunk +341 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/aec3/mock/mock_block_processor.h View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2608233002/1
3 years, 11 months ago (2017-01-03 12:00:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/d0263544107b4e76de0d4b4d05f4c77d5739e2c7
3 years, 11 months ago (2017-01-03 12:20:37 UTC) #5
hlundin-webrtc
On 2017/01/03 12:20:37, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 11 months ago (2017-01-09 13:10:27 UTC) #6
peah-webrtc
3 years, 11 months ago (2017-01-13 10:57:36 UTC) #7
Message was sent while issue was closed.
On 2017/01/09 13:10:27, hlundin-webrtc wrote:
> On 2017/01/03 12:20:37, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
https://chromium.googlesource.com/external/webrtc/+/d0263544107b4e76de0d4b4d0...
> 
> peah: did you create a tracking bug for the disabled death tests?

No, but I created one now
(https://bugs.chromium.org/p/webrtc/issues/detail?id=6985). Thanks for the
reminder!

Powered by Google App Engine
This is Rietveld 408576698