Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: webrtc/api/rtcstats_integrationtest.cc

Issue 2607933002: RTCMediaStreamTrackStats.framesDropped collected by RTCStatsCollector. (Closed)
Patch Set: Added unittests for webrtcvideoengine2 and receive_statistics_proxy Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/api/rtcstatscollector.cc » ('j') | webrtc/media/engine/webrtcvideoengine2_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/rtcstats_integrationtest.cc
diff --git a/webrtc/api/rtcstats_integrationtest.cc b/webrtc/api/rtcstats_integrationtest.cc
index 5ded4470ea5fb13d019e4f7a91e869f435bc08a8..451aa9773d7ce38e8a5b70f6f49cf56b23349540 100644
--- a/webrtc/api/rtcstats_integrationtest.cc
+++ b/webrtc/api/rtcstats_integrationtest.cc
@@ -442,11 +442,14 @@ class RTCStatsReportVerifier {
if (*media_stream_track.remote_source) {
verifier.TestMemberIsNonNegative<uint32_t>(
media_stream_track.frames_received);
+ verifier.TestMemberIsUndefined(media_stream_track.frames_decoded);
+ verifier.TestMemberIsNonNegative<uint32_t>(
+ media_stream_track.frames_dropped);
} else {
verifier.TestMemberIsUndefined(media_stream_track.frames_received);
+ verifier.TestMemberIsUndefined(media_stream_track.frames_decoded);
+ verifier.TestMemberIsUndefined(media_stream_track.frames_dropped);
}
- verifier.TestMemberIsUndefined(media_stream_track.frames_decoded);
- verifier.TestMemberIsUndefined(media_stream_track.frames_dropped);
verifier.TestMemberIsUndefined(media_stream_track.frames_corrupted);
verifier.TestMemberIsUndefined(media_stream_track.partial_frames_lost);
verifier.TestMemberIsUndefined(media_stream_track.full_frames_lost);
« no previous file with comments | « no previous file | webrtc/api/rtcstatscollector.cc » ('j') | webrtc/media/engine/webrtcvideoengine2_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698