Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: webrtc/media/engine/webrtcvideoengine2_unittest.cc

Issue 2607933002: RTCMediaStreamTrackStats.framesDropped collected by RTCStatsCollector. (Closed)
Patch Set: Added unittests for webrtcvideoengine2 and receive_statistics_proxy Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/engine/webrtcvideoengine2.cc ('k') | webrtc/video/receive_statistics_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/webrtcvideoengine2_unittest.cc
diff --git a/webrtc/media/engine/webrtcvideoengine2_unittest.cc b/webrtc/media/engine/webrtcvideoengine2_unittest.cc
index 4667ea8f3fff76a95071d2af78c4ac6c3e05f247..9a1314e2610c1974b70dd3fb892af2eb323addbc 100644
--- a/webrtc/media/engine/webrtcvideoengine2_unittest.cc
+++ b/webrtc/media/engine/webrtcvideoengine2_unittest.cc
@@ -3304,6 +3304,7 @@ TEST_F(WebRtcVideoChannel2Test, GetStatsTranslatesDecodeStatsCorrectly) {
stats.frame_counts.key_frames = 11;
stats.frame_counts.delta_frames = 12;
stats.frames_decoded = 13;
+ stats.frames_rendered = 12;
pbos-webrtc 2017/01/19 17:14:03 14, but nit/whatever
Taylor Brandstetter 2017/01/19 17:23:08 It would be reasonable to have a DCHECK for "frame
hbos 2017/01/23 12:12:15 Changed the order so that it's ..., 12, 13 (render
stream->SetStats(stats);
cricket::VideoMediaInfo info;
@@ -3322,6 +3323,7 @@ TEST_F(WebRtcVideoChannel2Test, GetStatsTranslatesDecodeStatsCorrectly) {
EXPECT_EQ(stats.frame_counts.key_frames + stats.frame_counts.delta_frames,
info.receivers[0].frames_received);
EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
+ EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
}
TEST_F(WebRtcVideoChannel2Test, GetStatsTranslatesReceivePacketStatsCorrectly) {
« no previous file with comments | « webrtc/media/engine/webrtcvideoengine2.cc ('k') | webrtc/video/receive_statistics_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698