Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 2607913002: RTCMediaStreamTrackStats.framesReceived collected by RTCStatsCollector. (Closed)

Created:
3 years, 11 months ago by hbos
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

RTCMediaStreamTrackStats.framesReceived collected by RTCStatsCollector. VideoReceiverInfo::frames_received added based on VideoReceiveStream::Stats::frame_counts (.key_frames + .delta_frames). BUG=webrtc:6757, chromium:659137, chromium:627816 Review-Url: https://codereview.webrtc.org/2607913002 Cr-Commit-Position: refs/heads/master@{#16185} Committed: https://chromium.googlesource.com/external/webrtc/+/42f6d2fb6ca224fc79cdb3cda9c2af886497fd6c

Patch Set 1 #

Patch Set 2 : Rebase with master #

Patch Set 3 : webrtcvideoengine2_unittest.cc updated #

Patch Set 4 : Rebase after RTCMediaStreamTrackStats being per-attachment #

Patch Set 5 : Rebase with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M webrtc/api/rtcstats_integrationtest.cc View 1 2 chunks +8 lines, -1 line 0 comments Download
M webrtc/api/rtcstatscollector.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/rtcstatscollector_unittest.cc View 1 2 3 4 4 chunks +4 lines, -0 lines 0 comments Download
M webrtc/api/stats/rtcstats_objects.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/base/mediachannel.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 29 (21 generated)
hbos
Please take a look, hta and deadbeef.
3 years, 11 months ago (2016-12-29 14:09:06 UTC) #5
hta-webrtc
lgtm for the single RTP receiver case, which is our currently spec'ed case, this looks ...
3 years, 11 months ago (2017-01-02 16:24:37 UTC) #8
Taylor Brandstetter
lgtm. As far as I can tell, this covers the simulcast case (at least for ...
3 years, 11 months ago (2017-01-04 23:33:48 UTC) #9
hbos
Please take a look pbos at webrtc/media/
3 years, 11 months ago (2017-01-18 14:52:24 UTC) #15
pbos-webrtc
lgtm for media/, thanks for adding the test too
3 years, 11 months ago (2017-01-18 16:19:58 UTC) #18
commit-bot: I haz the power
This CL has an open dependency (Issue 2641763003 Patch 20001). Please resolve the dependency and ...
3 years, 11 months ago (2017-01-18 16:20:20 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2607913002/140001
3 years, 11 months ago (2017-01-20 11:00:36 UTC) #26
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 11:56:55 UTC) #29
Message was sent while issue was closed.
Committed patchset #5 (id:140001) as
https://chromium.googlesource.com/external/webrtc/+/42f6d2fb6ca224fc79cdb3cda...

Powered by Google App Engine
This is Rietveld 408576698