Issue 2607533003: Fix a screen capture issue on retina macOS devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2607533003: Fix a screen capture issue on retina macOS devices. (Closed)

Created:
3 years, 12 months ago by Sergey Ulanov

Modified:
3 years, 12 months ago

Reviewers:

CC:
webrtc-reviews_webrtc.org

Target Ref:
refs/branch-heads/56

Project:
webrtc

Visibility:
Public.

Fix a screen capture issue on retina macOS devices. The CGDisplayStream API returns rects in physical pixel coordinates, not Density-Independent Pixel coordinates. The code was incorrectly re-applying the dip_to_pixel scaling. BUG=chromium:675490 Review-Url: https://codereview.webrtc.org/2588973002 Cr-Commit-Position: refs/heads/master@{#15720} (cherry picked from commit 494dff4c079910f0033e3ed63c975c791d6ded37) Review-Url: https://codereview.webrtc.org/2607533003 . Cr-Commit-Position: refs/branch-heads/56@{#11} Cr-Branched-From: 613152af11d6e9a4d046af3c48a7be7642dfcc68-refs/heads/master@{#15101} Committed: https://chromium.googlesource.com/external/webrtc/+/f4f8de6631c1b05be8bb57e622535e2ec73d89fb

Created: 3 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	webrtc/modules/desktop_capture/screen_capturer_mac.mm	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

Sergey Ulanov

3 years, 12 months ago (2016-12-27 19:45:04 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f4f8de6631c1b05be8bb57e622535e2ec73d89fb.