Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2606483002: Refactor webrtc/modules/utility for gn check (Closed)

Created:
3 years, 12 months ago by mbonadei
Modified:
3 years, 12 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Refactor webrtc/modules/utility for gn check The now checked target is: "//webrtc/modules/utility/*" BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2606483002 Cr-Commit-Position: refs/heads/master@{#15803} Committed: https://chromium.googlesource.com/external/webrtc/+/05afa8bce69c99a57c8ad5173c9a89b982cd20c6

Patch Set 1 #

Patch Set 2 : Adding .gn after chromium buildbots check #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M .gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/utility/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
mbonadei
3 years, 12 months ago (2016-12-23 16:45:27 UTC) #2
kjellander_webrtc
lgtm
3 years, 12 months ago (2016-12-27 06:14:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2606483002/40001
3 years, 12 months ago (2016-12-27 13:38:20 UTC) #6
commit-bot: I haz the power
3 years, 12 months ago (2016-12-27 13:40:19 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/05afa8bce69c99a57c8ad5173...

Powered by Google App Engine
This is Rietveld 408576698