UdpTransport:IsIpAddressValid: Added extra :: check for ipv6

UdpTransport:IsIpAddressValid: Added extra :: check for ipv6

The code previously allowed ipv6 addresses with less than eight sections even without all-zero sections being compacted by a ::.

BUG=webrtc:1028
Review-Url: https://codereview.webrtc.org/2606383003
Cr-Commit-Position: refs/heads/master@{#16108}
Committed: https://chromium.googlesource.com/external/webrtc/+/ece0571d44a84036d696b10d4d2986944faa15da

[ossu, 2017-01-03 16:15:04]

The CQ bit was checked by ossu@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 16:15:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-03 17:42:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 17:42:58]

Dry run: This issue passed the CQ dry run.

[ossu, 2017-01-04 10:26:02]

Description was changed from

==========
UdpTransport:IsIpAddressValid: Added extra :: check for ipv6

BUG=webrtc:1028
==========

to

==========
UdpTransport:IsIpAddressValid: Added extra :: check for ipv6

The code previously allowed ipv6 addresses with less than eight sections even
without all-zero sections being compacted by a ::.

BUG=webrtc:1028
==========

[ossu, 2017-01-04 10:26:02]

ossu@webrtc.org changed reviewers:
+ tina.legrand@webrtc.org

[ossu, 2017-01-04 10:27:16]

PTAL. This change doesn't really fix an issue we've had with the code, since
it's only used in tests, but we might as well fix it as well and close the
associated bug.

[ossu, 2017-01-09 12:36:28]

On 2017/01/04 10:27:16, ossu wrote:
> PTAL. This change doesn't really fix an issue we've had with the code, since
> it's only used in tests, but we might as well fix it as well and close the
> associated bug.

Nudge. If you'd prefer it, I could pick another reviewer now that people are
coming back to work after the holidays.

[ossu, 2017-01-13 09:09:12]

ossu@webrtc.org changed reviewers:
+ kwiberg@webrtc.org
- tina.legrand@webrtc.org

[ossu, 2017-01-13 09:09:12]

Karl, could you PTAL at this one. It's just a small fix in code we only use for
testing.

[kwiberg-webrtc, 2017-01-13 09:19:03]

lgtm

But I'm skeptical that it's a good idea in the first place to need homegrown
test-only code in C++ that validates ipv6 addresses...

[ossu, 2017-01-17 09:14:58]

The CQ bit was checked by ossu@webrtc.org

[commit-bot: I haz the power, 2017-01-17 09:15:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-17 10:31:38]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484644498238430, "parent_rev":
"da5e9d04f59ed88d1db4a364ca23ac8466d7ec8b", "commit_rev":
"ece0571d44a84036d696b10d4d2986944faa15da"}

[commit-bot: I haz the power, 2017-01-17 10:31:41]

Description was changed from

==========
UdpTransport:IsIpAddressValid: Added extra :: check for ipv6

The code previously allowed ipv6 addresses with less than eight sections even
without all-zero sections being compacted by a ::.

BUG=webrtc:1028
==========

to

==========
UdpTransport:IsIpAddressValid: Added extra :: check for ipv6

The code previously allowed ipv6 addresses with less than eight sections even
without all-zero sections being compacted by a ::.

BUG=webrtc:1028

Review-Url: https://codereview.webrtc.org/2606383003
Cr-Commit-Position: refs/heads/master@{#16108}
Committed:
https://chromium.googlesource.com/external/webrtc/+/ece0571d44a84036d696b10d4...
==========

[commit-bot: I haz the power, 2017-01-17 10:31:42]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/ece0571d44a84036d696b10d4...