Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2605123002: Replace basictypes.h with stddef.h for size_t. (Closed)

Created:
3 years, 11 months ago by pbos-webrtc
Modified:
3 years, 11 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace basictypes.h with stddef.h for size_t. Files only making use of size_t from basictypes.h are replaced with stddef.h, except in cases where they already for instance use stdio.h or stdlib.h that already provide size_t. BUG=webrtc:6853 R=tommi@webrtc.org Review-Url: https://codereview.webrtc.org/2605123002 Cr-Commit-Position: refs/heads/master@{#15865} Committed: https://chromium.googlesource.com/external/webrtc/+/9baddf25b9cb4b8c4d0813c9982dae9425d6fa98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M webrtc/api/jsep.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/api/mediastreaminterface.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/base/ratelimiter.h View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/base/scopedptrcollection.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/base/stream.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/base/stringencode.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/base/stringutils.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/media/engine/fakewebrtcvoiceengine.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
pbos-webrtc
PTAL whenever :)
3 years, 11 months ago (2016-12-28 22:10:40 UTC) #1
tommi
lgtm
3 years, 11 months ago (2017-01-02 13:59:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2605123002/1
3 years, 11 months ago (2017-01-02 13:59:16 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 14:44:45 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/9baddf25b9cb4b8c4d0813c99...

Powered by Google App Engine
This is Rietveld 408576698