Make FakeEncoder and FakeH264Encoder thread safe.

Make FakeEncoder and FakeH264Encoder thread safe.

The MultithreadedFakeH264Encoder is a derived class from FakeEncoder
and FakeH264Encoder, and these should thus also be thread safe.

TESTED=Ran "out/Tsan/video_engine_tests --gtest_filter="*Multithreaded*" --gtest_repeat=100" with is_debug=false, dcheck_always_on=true, is_tsan=true.

BUG=webrtc:6943
Review-Url: https://codereview.webrtc.org/2604403003
Cr-Commit-Position: refs/heads/master@{#16093}
Committed: https://chromium.googlesource.com/external/webrtc/+/e78d26669eeedd862150ff799d1e174bed1cfd28

[brandtr, 2017-01-04 10:07:30]

Patchset #4 (id:60001) has been deleted

[brandtr, 2017-01-04 10:32:58]

Description was changed from

==========
Make FakeEncoder and FakeH264Encoder thread safe.

The MultithreadedFakeH264Encoder is a derived class from FakeEncoder
and FakeH264Encoder, and the these should thus also be thread safe.

BUG=webrtc:6943
==========

to

==========
Make FakeEncoder and FakeH264Encoder thread safe.

The MultithreadedFakeH264Encoder is a derived class from FakeEncoder
and FakeH264Encoder, and these should thus also be thread safe.

TESTED=Ran "out/Tsan/video_engine_tests --gtest_filter="*Multithreaded*"
--gtest_repeat=100" with is_debug=false, dcheck_always_on=true, is_tsan=true.

BUG=webrtc:6943
==========

[brandtr, 2017-01-04 10:33:04]

Patchset #4 (id:80001) has been deleted

[brandtr, 2017-01-04 10:45:52]

Patchset #4 (id:100001) has been deleted

[brandtr, 2017-01-04 12:38:42]

brandtr@webrtc.org changed reviewers:
+ asapersson@webrtc.org, kjellander@webrtc.org

[brandtr, 2017-01-04 12:38:43]

Please have a look.

[kjellander_webrtc, 2017-01-04 14:01:20]

rubberstamp lgtm for webrtc/test.
I defer the main review to Åsa.

[brandtr, 2017-01-09 07:58:19]

Rebase.

[brandtr, 2017-01-12 15:06:14]

Rebase.

[brandtr, 2017-01-16 10:16:31]

Åsa: description of why I copy the whole frame buffer.

https://codereview.webrtc.org/2604403003/diff/160001/webrtc/test/fake_encoder.cc
File webrtc/test/fake_encoder.cc (right):

https://codereview.webrtc.org/2604403003/diff/160001/webrtc/test/fake_encoder...
webrtc/test/fake_encoder.cc:140: memcpy(encoded_buffer.get(), encoded_buffer_,
num_encoded_bytes);
I make a copy of the fake frame buffer, since the H264 fake encoder writes into
the frame buffer here:
https://cs.chromium.org/chromium/src/third_party/webrtc/test/fake_encoder.cc?...
which becomes a race with the packetizer here:
https://cs.chromium.org/chromium/src/third_party/webrtc/modules/rtp_rtcp/sour...

This is the race that was found by tsan :)

[brandtr, 2017-01-16 10:26:39]

Rebase.

[åsapersson, 2017-01-16 11:31:53]

lgtm

[brandtr, 2017-01-16 12:30:59]

The CQ bit was checked by brandtr@webrtc.org

[brandtr, 2017-01-16 12:30:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2604403003/#ps180001 (title:
"Rebase.")

[commit-bot: I haz the power, 2017-01-16 12:31:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-16 13:57:17]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1484569859522390,
"parent_rev": "037b93af1719bd35ebf08cdfc2b6691b61a29f88", "commit_rev":
"e78d26669eeedd862150ff799d1e174bed1cfd28"}

[commit-bot: I haz the power, 2017-01-16 13:57:19]

Description was changed from

==========
Make FakeEncoder and FakeH264Encoder thread safe.

The MultithreadedFakeH264Encoder is a derived class from FakeEncoder
and FakeH264Encoder, and these should thus also be thread safe.

TESTED=Ran "out/Tsan/video_engine_tests --gtest_filter="*Multithreaded*"
--gtest_repeat=100" with is_debug=false, dcheck_always_on=true, is_tsan=true.

BUG=webrtc:6943
==========

to

==========
Make FakeEncoder and FakeH264Encoder thread safe.

The MultithreadedFakeH264Encoder is a derived class from FakeEncoder
and FakeH264Encoder, and these should thus also be thread safe.

TESTED=Ran "out/Tsan/video_engine_tests --gtest_filter="*Multithreaded*"
--gtest_repeat=100" with is_debug=false, dcheck_always_on=true, is_tsan=true.

BUG=webrtc:6943

Review-Url: https://codereview.webrtc.org/2604403003
Cr-Commit-Position: refs/heads/master@{#16093}
Committed:
https://chromium.googlesource.com/external/webrtc/+/e78d26669eeedd862150ff799...
==========

[commit-bot: I haz the power, 2017-01-16 13:57:21]

Committed patchset #7 (id:180001) as
https://chromium.googlesource.com/external/webrtc/+/e78d26669eeedd862150ff799...