Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2604043002: Replace basictypes.h with stdint.h for int_t types. (Closed)

Created:
3 years, 11 months ago by pbos-webrtc
Modified:
3 years, 11 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, zhuangzesen_agora.io, henrika_webrtc, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace basictypes.h with stdint.h for int_t types. Removes basictypes.h for types that only makes use of it for fixed-size-int typedefs and replaces it with stdint.h. BUG=webrtc:6853 R=tommi@webrtc.org Review-Url: https://codereview.webrtc.org/2604043002 Cr-Commit-Position: refs/heads/master@{#15867} Committed: https://chromium.googlesource.com/external/webrtc/+/7fd1a753005ca93e8bd934a55808a2137b0ad84f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -35 lines) Patch
M webrtc/api/rtpreceiver.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/base/byteorder_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/base/network.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/base/rtccertificate.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/base/systeminfo.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/base/task.h View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/base/taskrunner.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/base/timedelta.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/base/timestampaligner.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/base/timeutils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/base/window.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/call/flexfec_receive_stream.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/call/flexfec_receive_stream_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/examples/peerconnection/client/defaults.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/media/base/streamparams.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/media/base/videocapturer.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/media/base/videocommon.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/media/devices/gtkvideorenderer.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/playout_delay_oracle.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_extensions.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/time_util.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/h264_sprop_parameter_sets_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/utility/default_video_bitrate_allocator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/utility/simulcast_rate_allocator.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/p2p/base/candidate.h View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/p2p/stunprober/stunprober_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/pc/currentspeakermonitor.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/pc/externalhmac.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/sdk/android/src/jni/androidnetworkmonitor_jni.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/system_wrappers/include/ntp_time.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/test/frame_utils.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
pbos-webrtc
Also PTAL whenever. :)
3 years, 11 months ago (2016-12-28 22:22:01 UTC) #1
tommi
lgtm
3 years, 11 months ago (2017-01-02 14:01:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2604043002/1
3 years, 11 months ago (2017-01-02 14:01:05 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/7fd1a753005ca93e8bd934a55808a2137b0ad84f
3 years, 11 months ago (2017-01-02 14:58:49 UTC) #13
pbos-webrtc
3 years, 11 months ago (2017-01-02 15:32:06 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2603203003/ by pbos@webrtc.org.

The reason for reverting is: Very likely cause of Chromium import bot breakage
(unused function '__cpuid'), TBD why..

Powered by Google App Engine
This is Rietveld 408576698