Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2603993002: Revert of Disable flaky test VideoProcessorIntegrationTest.ProcessNoLossChangeFrameRateFrameDropVP9 (Closed)

Created:
3 years, 11 months ago by kjellander_webrtc
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Disable flaky test VideoProcessorIntegrationTest.ProcessNoLossChangeFrameRateFrameDropVP9 (patchset #1 id:1 of https://codereview.webrtc.org/2568743007/ ) Reason for revert: Trying to re-enable this test as we're now using a newer Clang version (289944-2). Original issue's description: > Disable flaky test VideoProcessorIntegrationTest.ProcessNoLossChangeFrameRateFrameDropVP9 > > This test is flaky on all platforms, not just Android. Disabling it entirely until webrtc:6057 is fixed. > > BUG=webrtc:6057 > > Committed: https://crrev.com/bb66ec35739830847bfb0146cd029ca41421b2d8 > Cr-Commit-Position: refs/heads/master@{#15594} TBR=marpan@webrtc.org,sprang@webrtc.org,skvlad@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6057 Review-Url: https://codereview.webrtc.org/2603993002 Cr-Commit-Position: refs/heads/master@{#15821} Committed: https://chromium.googlesource.com/external/webrtc/+/94b880178a81b6ad896cad305154091be478cc10

Patch Set 1 #

Patch Set 2 : Also enabling ProcessNoLossChangeFrameRateFrameDropVP9 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc View 1 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kjellander_webrtc
Created Revert of Disable flaky test VideoProcessorIntegrationTest.ProcessNoLossChangeFrameRateFrameDropVP9
3 years, 11 months ago (2016-12-28 14:15:19 UTC) #1
kjellander_webrtc
Trying to enable these now as we're on a newer Clang version
3 years, 11 months ago (2016-12-28 14:18:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2603993002/40001
3 years, 11 months ago (2016-12-28 14:18:22 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2016-12-28 15:22:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/94b880178a81b6ad896cad305...

Powered by Google App Engine
This is Rietveld 408576698