Merge RTCConfiguration with RTCMediaConstraints in Java/Obj-C wrappers.

Merge RTCConfiguration with RTCMediaConstraints in Java/Obj-C wrappers.

The intention of SetConfiguration is that it modifies the configuration,
while keeping the constraints passed into CreatePeerConnection. Right
now that's now happening. See bug for more explanation.

BUG=webrtc:6942
Review-Url: https://codereview.webrtc.org/2603653002
Cr-Commit-Position: refs/heads/master@{#15974}
Committed: https://chromium.googlesource.com/external/webrtc/+/5d0b6d8da307dda23e5fb02fd998a4136e41360b

[Taylor Brandstetter, 2016-12-24 21:26:33]

The CQ bit was checked by deadbeef@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-24 21:26:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-24 21:29:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-24 21:29:52]

Dry run: Try jobs failed on following builders:
  ios32_sim_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/13680)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/16033)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/21259)

[Taylor Brandstetter, 2016-12-24 21:31:02]

deadbeef@webrtc.org changed reviewers:
+ magjed@webrtc.org, tkchin@webrtc.org

[Taylor Brandstetter, 2016-12-24 21:31:03]

magjed: PTAL at Java code
tkchin: PTAL at Obj-C code

[Taylor Brandstetter, 2017-01-05 05:28:46]

deadbeef@webrtc.org changed reviewers:
+ glaznev@webrtc.org
- magjed@webrtc.org

[Taylor Brandstetter, 2017-01-05 05:28:46]

Alex, can you review since Magnus is OOO? Thanks.

[AlexG, 2017-01-05 18:54:21]

lgtm

[Taylor Brandstetter, 2017-01-09 20:31:08]

deadbeef@webrtc.org changed reviewers:
- glaznev@webrtc.org

[Taylor Brandstetter, 2017-01-09 20:31:09]

Pinging Zeke. See bug for more explanation of why this is needed.

[tkchin_webrtc, 2017-01-09 21:56:36]

https://codereview.webrtc.org/2603653002/diff/80001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm (right):

https://codereview.webrtc.org/2603653002/diff/80001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm:210:
std::unique_ptr<webrtc::MediaConstraints> _nativeConstraints;
Is this safe? Does peerconnection take ownership of this at all?

[Taylor Brandstetter, 2017-01-09 22:03:46]

https://codereview.webrtc.org/2603653002/diff/80001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm (right):

https://codereview.webrtc.org/2603653002/diff/80001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm:210:
std::unique_ptr<webrtc::MediaConstraints> _nativeConstraints;
On 2017/01/09 21:56:36, tkchin_webrtc wrote:
> Is this safe? Does peerconnection take ownership of this at all?

Yes, it's safe, and n,o nothing else takes ownership. Notice that now the
constraints aren't even passed into the PeerConnection or PeerConnectionFactory,
they're only passed into CopyConstraintsIntoRtcConfiguration.

[tkchin_webrtc, 2017-01-09 22:35:30]

lgtm

https://codereview.webrtc.org/2603653002/diff/80001/webrtc/sdk/objc/Framework...
File webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm (right):

https://codereview.webrtc.org/2603653002/diff/80001/webrtc/sdk/objc/Framework...
webrtc/sdk/objc/Framework/Classes/RTCPeerConnection.mm:210:
std::unique_ptr<webrtc::MediaConstraints> _nativeConstraints;
On 2017/01/09 22:03:45, Taylor Brandstetter wrote:
> On 2017/01/09 21:56:36, tkchin_webrtc wrote:
> > Is this safe? Does peerconnection take ownership of this at all?
> 
> Yes, it's safe, and n,o nothing else takes ownership. Notice that now the
> constraints aren't even passed into the PeerConnection or
PeerConnectionFactory,
> they're only passed into CopyConstraintsIntoRtcConfiguration.

Ah, so it is. Thanks.

[Taylor Brandstetter, 2017-01-09 22:52:42]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2017-01-09 22:52:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-10 00:05:29]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484002362424510,
"parent_rev": "953c2cea5ef35e2278a512dfd466c47cca2203a6", "commit_rev":
"5d0b6d8da307dda23e5fb02fd998a4136e41360b"}

[commit-bot: I haz the power, 2017-01-10 00:05:32]

Description was changed from

==========
Merge RTCConfiguration with RTCMediaConstraints in Java/Obj-C wrappers.

The intention of SetConfiguration is that it modifies the configuration,
while keeping the constraints passed into CreatePeerConnection. Right
now that's now happening. See bug for more explanation.

BUG=webrtc:6942
==========

to

==========
Merge RTCConfiguration with RTCMediaConstraints in Java/Obj-C wrappers.

The intention of SetConfiguration is that it modifies the configuration,
while keeping the constraints passed into CreatePeerConnection. Right
now that's now happening. See bug for more explanation.

BUG=webrtc:6942

Review-Url: https://codereview.webrtc.org/2603653002
Cr-Commit-Position: refs/heads/master@{#15974}
Committed:
https://chromium.googlesource.com/external/webrtc/+/5d0b6d8da307dda23e5fb02fd...
==========

[commit-bot: I haz the power, 2017-01-10 00:05:33]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/5d0b6d8da307dda23e5fb02fd...