Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2603293002: Revert of Added first layer of the echo canceller 3 functionality (Closed)

Created:
3 years, 11 months ago by terelius
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Added first layer of the echo canceller 3 functionality (patchset #13 id:240001 of https://codereview.webrtc.org/2584493002/ ) Reason for revert: Memcheck buildbot detected memory leaks in the death tests. The code looks fine to me, but please investigate what causes the error and reland. Original issue's description: > Added first layer of the echo canceller 3 functionality. > > This CL adds the first layer of the echo canceller 3. > All of the code is as it should, apart from > block_processor.* which only contains placeholder > functionality. (Upcoming CLs will add proper > functionality into those files.) > > > > BUG=webrtc:6018 > > Review-Url: https://codereview.webrtc.org/2584493002 > Cr-Commit-Position: refs/heads/master@{#15861} > Committed: https://chromium.googlesource.com/external/webrtc/+/38fd1758e90bcdc7690a552e7ef0ec0d143d2f30 TBR=ivoc@webrtc.org,aleloi@webrtc.org,henrik.lundin@webrtc.org,peah@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6018 Review-Url: https://codereview.webrtc.org/2603293002 Cr-Commit-Position: refs/heads/master@{#15877} Committed: https://chromium.googlesource.com/external/webrtc/+/7946b546db74d0af2badd1002eaab01ed837b194

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2522 lines) Patch
M webrtc/modules/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/BUILD.gn View 1 chunk +0 lines, -9 lines 0 comments Download
D webrtc/modules/audio_processing/aec3/aec3_constants.h View 1 chunk +0 lines, -52 lines 0 comments Download
D webrtc/modules/audio_processing/aec3/block_framer.h View 1 chunk +0 lines, -47 lines 0 comments Download
D webrtc/modules/audio_processing/aec3/block_framer.cc View 1 chunk +0 lines, -59 lines 0 comments Download
D webrtc/modules/audio_processing/aec3/block_framer_unittest.cc View 1 chunk +0 lines, -261 lines 0 comments Download
D webrtc/modules/audio_processing/aec3/block_processor.h View 1 chunk +0 lines, -44 lines 0 comments Download
D webrtc/modules/audio_processing/aec3/block_processor.cc View 1 chunk +0 lines, -73 lines 0 comments Download
D webrtc/modules/audio_processing/aec3/block_processor_unittest.cc View 1 chunk +0 lines, -141 lines 0 comments Download
D webrtc/modules/audio_processing/aec3/cascaded_biquad_filter.h View 1 chunk +0 lines, -58 lines 0 comments Download
D webrtc/modules/audio_processing/aec3/cascaded_biquad_filter.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D webrtc/modules/audio_processing/aec3/cascaded_biquad_filter_unittest.cc View 1 chunk +0 lines, -98 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/echo_canceller3.h View 3 chunks +4 lines, -89 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/echo_canceller3.cc View 2 chunks +11 lines, -312 lines 0 comments Download
D webrtc/modules/audio_processing/aec3/echo_canceller3_unittest.cc View 1 chunk +0 lines, -717 lines 0 comments Download
D webrtc/modules/audio_processing/aec3/frame_blocker.h View 1 chunk +0 lines, -48 lines 0 comments Download
D webrtc/modules/audio_processing/aec3/frame_blocker.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D webrtc/modules/audio_processing/aec3/frame_blocker_unittest.cc View 1 chunk +0 lines, -341 lines 0 comments Download
D webrtc/modules/audio_processing/aec3/mock/mock_block_processor.h View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
terelius
Created Revert of Added first layer of the echo canceller 3 functionality
3 years, 11 months ago (2017-01-02 21:44:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2603293002/1
3 years, 11 months ago (2017-01-02 21:44:40 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 21:44:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/7946b546db74d0af2badd1002...

Powered by Google App Engine
This is Rietveld 408576698