Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2603203002: Add cleanup_links.py script that runs before sync. (Closed)

Created:
3 years, 11 months ago by kjellander_webrtc
Modified:
3 years, 11 months ago
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add cleanup_links.py script that runs before sync. This should reduce/eliminate the amount of manual cleanup users have to do to sync past 177567c518b121731e507e9b9c4049c4dc96e4c8 (#15754). This is essentially a stripped down version of https://chromium.googlesource.com/external/webrtc/+/526248779a6315b02f5ca36a2f76122d3914b67e/setup_links.py which only does the link cleaning + adds removal of the links db. BUG=webrtc:5006 NOTRY=True Review-Url: https://codereview.webrtc.org/2603203002 Cr-Commit-Position: refs/heads/master@{#15897} Committed: https://chromium.googlesource.com/external/webrtc/+/e3b11aa565b6698c36502b86d0ee0541c34cf245

Patch Set 1 : . #

Patch Set 2 : Move to pre_deps_hooks #

Patch Set 3 : Cleaning of the links database file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -2 lines) Patch
M .gitignore View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M DEPS View 1 1 chunk +10 lines, -0 lines 0 comments Download
A cleanup_links.py View 1 2 1 chunk +104 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
kjellander_webrtc
This should reduce the cleaning needed for users syncing from old checkouts, since they'll have ...
3 years, 11 months ago (2017-01-04 11:29:20 UTC) #4
ehmaldonado_webrtc
lgtm
3 years, 11 months ago (2017-01-04 12:01:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2603203002/60001
3 years, 11 months ago (2017-01-04 12:04:18 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/11897)
3 years, 11 months ago (2017-01-04 12:08:28 UTC) #11
henrika_webrtc
LGTM
3 years, 11 months ago (2017-01-04 12:25:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2603203002/60001
3 years, 11 months ago (2017-01-04 13:33:14 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 13:35:29 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/e3b11aa565b6698c36502b86d...

Powered by Google App Engine
This is Rietveld 408576698