Refactor bitrate_controller, remote_bitrate_estimator and congestion_contoller for gn check

webrtc/modules/remote_bitrate_estimator/BUILD.gn

Index: webrtc/modules/remote_bitrate_estimator/BUILD.gn
diff --git a/webrtc/modules/remote_bitrate_estimator/BUILD.gn b/webrtc/modules/remote_bitrate_estimator/BUILD.gn
index 67aa7c8fd4d7303a7af7150117e6438c1dc78278..cbf0199464ce34344c31b6b7d1bf248c78e2a84c 100644
--- a/webrtc/modules/remote_bitrate_estimator/BUILD.gn
+++ b/webrtc/modules/remote_bitrate_estimator/BUILD.gn
@@ -9,6 +9,11 @@
 import("../../build/webrtc.gni")
 
 rtc_static_library("remote_bitrate_estimator") {
+  # TODO(mbonadei): Remove (bugs.webrtc.org/6828)
+  # Errors on cyclic dependency with:
+  # rtp_rtcp:rtp_rtcp if enabled.
+  check_includes = false
+
   sources = [
     "aimd_rate_control.cc",
     "aimd_rate_control.h",
@@ -46,6 +51,7 @@ rtc_static_library("remote_bitrate_estimator") {
 
   deps = [
     "../..:webrtc_common",
+    "../../base:rtc_base",
     "../../base:rtc_base_approved",
     "../../system_wrappers",
   ]
@@ -102,9 +108,18 @@ if (rtc_include_tests) {
     }
 
     deps = [
+      ":remote_bitrate_estimator",
+      "../..:webrtc_common",
+      "../../base:gtest_prod",
+      "../../base:rtc_base",
+      "../../base:rtc_base_approved",
+      "../../system_wrappers:system_wrappers",

[kjellander_webrtc, 2016/12/27 06:22:55]

Please leave out explicit target naming here. "../../system_wrappers", will give
you the same, but is easier to read.

[mbonadei, 2016/12/27 14:51:17]

Ok, I also removed the explicit target naming from other locations (eg:
"../rtp_rtcp:rtp_rtcp", "../bitrate_controller:bitrate_controller").

       "../../test:test_support",
+      "../../voice_engine:voice_engine",

[kjellander_webrtc, 2016/12/27 06:22:55]

This is an odd dependency. I think it was introduced with 
https://webrtc-codereview.appspot.com/43299004
Stefan: can you consider doing some refactoring to get rid of it?

+      "../bitrate_controller:bitrate_controller",
       "../congestion_controller",
       "../pacing",
+      "../rtp_rtcp:rtp_rtcp",
       "//testing/gmock",
       "//testing/gtest",
     ]