Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2600153004: Adding support for Unified Plan offer/answer negotiation.

Created:
3 years, 11 months ago by Taylor Brandstetter
Modified:
3 years, 5 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding support for Unified Plan offer/answer negotiation. Though only to the mediasession.cc layer, before anyone gets too excited. This layer takes in a simplified "options" struct and the current local description, and generates a new offer/answer. Previously the options struct assumed there would only be one media description per media type (audio/video), but it now supports N number of audio/video descriptions. The next step is to add the ability for PeerConnection/WebRtcSession to create "options" to represent multiple RtpTransceivers, and apply the Unified Plan descriptions correctly. Right now, only Plan B descriptions will be generated in unit tests.

Patch Set 1 #

Patch Set 2 : Made changes to PeerConnection, got libjingle_peerconnection target compiling. #

Patch Set 3 : Got tests working (aside from ones that need to be completely rewritten) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1170 lines, -927 lines) Patch
M webrtc/api/peerconnection.h View 1 2 3 chunks +4 lines, -38 lines 0 comments Download
M webrtc/api/peerconnection.cc View 1 2 9 chunks +338 lines, -203 lines 0 comments Download
M webrtc/api/peerconnection_unittest.cc View 1 2 3 chunks +18 lines, -7 lines 0 comments Download
M webrtc/api/peerconnectioninterface_unittest.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/api/webrtcsession_unittest.cc View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M webrtc/api/webrtcsessiondescriptionfactory.cc View 1 2 8 chunks +46 lines, -44 lines 0 comments Download
M webrtc/pc/mediasession.h View 1 2 7 chunks +108 lines, -95 lines 0 comments Download
M webrtc/pc/mediasession.cc View 1 2 28 chunks +651 lines, -538 lines 0 comments Download

Messages

Total messages: 2 (2 generated)
Taylor Brandstetter
Description was changed from ========== Working on Unified Plan SDP. Got to line 1460 of ...
3 years, 11 months ago (2017-01-16 11:39:54 UTC) #1
Taylor Brandstetter
3 years, 10 months ago (2017-02-21 18:03:03 UTC) #2
Description was changed from

==========
Adding support for Unified Plan offer/answer negotiation.

Though only to the mediasession.cc layer, before anyone gets too excited.

This layer takes in a simplified "options" struct and the current local
description,
and generates a new offer/answer. Previously the options struct assumed there
would
only be one media description per media type (audio/video), but it now supports
N number of audio/video descriptions.

The next step is to add the ability for PeerConnection/WebRtcSession to create
"options" to represent multiple RtpTransceivers, and apply the Unified Plan
descriptions correctly. Right now, unified plan descriptions will still only be
generated in unit tests.
==========

to

==========
Adding support for Unified Plan offer/answer negotiation.

Though only to the mediasession.cc layer, before anyone gets too excited.

This layer takes in a simplified "options" struct and the current local
description,
and generates a new offer/answer. Previously the options struct assumed there
would
only be one media description per media type (audio/video), but it now supports
N number of audio/video descriptions.

The next step is to add the ability for PeerConnection/WebRtcSession to create
"options" to represent multiple RtpTransceivers, and apply the Unified Plan
descriptions correctly. Right now, only Plan B descriptions will be
generated in unit tests.
==========

Powered by Google App Engine
This is Rietveld 408576698