Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2599673003: If network enumeration fails, try binding to the "ANY" address. (Closed)

Created:
4 years ago by Taylor Brandstetter
Modified:
3 years, 12 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

If network enumeration fails, try binding to the "ANY" address. This isn't as good as being able to enumerate all networks, but it's better than doing nothing; it still will provide STUN/TURN candidates for the default route if one exists. BUG=webrtc:6932 Review-Url: https://codereview.webrtc.org/2599673003 Cr-Commit-Position: refs/heads/master@{#15766} Committed: https://chromium.googlesource.com/external/webrtc/+/e97389c505e0dce02242f3ef13013279868c290e

Patch Set 1 #

Patch Set 2 : Getting rid of redundant test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -18 lines) Patch
M webrtc/base/network.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/client/basicportallocator.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/p2p/client/basicportallocator_unittest.cc View 1 6 chunks +47 lines, -18 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
Taylor Brandstetter
Can you take a look, Honghai? Thanks!
4 years ago (2016-12-22 19:14:51 UTC) #2
Taylor Brandstetter
I forgot Honghai is OOO already. Peter?
4 years ago (2016-12-22 21:41:19 UTC) #4
pthatcher2
lgtm
4 years ago (2016-12-22 23:12:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2599673003/1
4 years ago (2016-12-22 23:19:16 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/11725)
4 years ago (2016-12-22 23:23:26 UTC) #10
pthatcher1
lgtm
4 years ago (2016-12-22 23:33:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2599673003/20001
4 years ago (2016-12-22 23:37:08 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2599673003/20001
4 years ago (2016-12-23 05:27:12 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/e97389c505e0dce02242f3ef13013279868c290e
4 years ago (2016-12-23 09:43:49 UTC) #20
honghaiz3
3 years, 12 months ago (2016-12-27 18:28:42 UTC) #22
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698