Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2599013002: Clean up ramp-up tests and make sure they all pass. (Closed)

Created:
4 years ago by stefan-webrtc
Modified:
3 years, 11 months ago
Reviewers:
terelius, mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Clean up ramp-up tests and make sure they all pass. BUG=webrtc:6935 Review-Url: https://codereview.webrtc.org/2599013002 Cr-Commit-Position: refs/heads/master@{#15960} Committed: https://chromium.googlesource.com/external/webrtc/+/38d8b3c9b0ffe4010a8dc2cc562c60ec366758fe

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -108 lines) Patch
M webrtc/call/rampup_tests.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/call/rampup_tests.cc View 1 6 chunks +23 lines, -108 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
stefan-webrtc
4 years ago (2016-12-22 12:47:57 UTC) #4
mflodman
One comment, then LGTM. https://codereview.webrtc.org/2599013002/diff/1/webrtc/call/rampup_tests.h File webrtc/call/rampup_tests.h (right): https://codereview.webrtc.org/2599013002/diff/1/webrtc/call/rampup_tests.h#newcode127 webrtc/call/rampup_tests.h:127: int GetHighCapacity() const; Wdyt of ...
3 years, 11 months ago (2017-01-03 13:17:00 UTC) #7
stefan-webrtc
https://codereview.webrtc.org/2599013002/diff/1/webrtc/call/rampup_tests.h File webrtc/call/rampup_tests.h (right): https://codereview.webrtc.org/2599013002/diff/1/webrtc/call/rampup_tests.h#newcode127 webrtc/call/rampup_tests.h:127: int GetHighCapacity() const; On 2017/01/03 13:17:00, mflodman wrote: > ...
3 years, 11 months ago (2017-01-09 11:34:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2599013002/20001
3 years, 11 months ago (2017-01-09 11:34:55 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 12:19:28 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/38d8b3c9b0ffe4010a8dc2cc5...

Powered by Google App Engine
This is Rietveld 408576698