Refactor webrtc/modules/rtp_rtcp for GN check

Refactor webrtc/modules/rtp_rtcp for GN check

This moves some GN check configurations out of .gn to individual
targets.

This commit also removes the source file 'mocks/mock_rtp_rtcp.h' from
the static_library 'rtp_rtcp' because it depends on a 'testonly = true'
target. After a check this seems only included in the unitest code:

$ grep -Rn "mocks/mock_rtp_rtcp.h" webrtc/modules/rtp_rtcp/
webrtc/modules/rtp_rtcp/source/ulpfec_receiver_unittest.cc:18:#include "webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h"
webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc:17:#include "webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h"

This commit also removes the dependency on
'//webrt/modules/video_coding' because it seems that the following
include can be removed:

#include "webrtc/modules/video_coding/include/video_coding_defines.h"

The now checked target is:
"//webrtc/modules/rtp_rtcp/*"

BUG=webrtc:6828
NOTRY=True

Review-Url: https://codereview.webrtc.org/2598963002
Cr-Commit-Position: refs/heads/master@{#15760}
Committed: https://chromium.googlesource.com/external/webrtc/+/ebafdc84843256bac7f125ff637d7e006f67d595

[mbonadei, 2016-12-22 08:22:20]

Description was changed from

==========
Refactor webrtc/modules/rtp_rtcp for GN check

This moves some GN check configurations out of .gn to individual
targets.

This commit also removes the source file 'mocks/mock_rtp_rtcp.h' from
the static_library 'rtp_rtcp' because it depends on a 'testonly = true'
target. After a check this seems only included in the unitest code:

$ grep -Rn "mocks/mock_rtp_rtcp.h" webrtc/modules/rtp_rtcp/
webrtc/modules/rtp_rtcp/source/ulpfec_receiver_unittest.cc:18:#include
"webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h"
webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc:17:#include
"webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h"

This commit also removes the dependency on
'//webrt/modules/video_coding' because it seems that the following
include can be removed:

The now checked target is:
"//webrtc/modules/rtp_rtcp/*"

BUG=webrtc:6828
NOTRY=True
==========

to

==========
Refactor webrtc/modules/rtp_rtcp for GN check

This moves some GN check configurations out of .gn to individual
targets.

This commit also removes the source file 'mocks/mock_rtp_rtcp.h' from
the static_library 'rtp_rtcp' because it depends on a 'testonly = true'
target. After a check this seems only included in the unitest code:

$ grep -Rn "mocks/mock_rtp_rtcp.h" webrtc/modules/rtp_rtcp/
webrtc/modules/rtp_rtcp/source/ulpfec_receiver_unittest.cc:18:#include
"webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h"
webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc:17:#include
"webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h"

This commit also removes the dependency on
'//webrt/modules/video_coding' because it seems that the following
include can be removed:

#include "webrtc/modules/video_coding/include/video_coding_defines.h"

The now checked target is:
"//webrtc/modules/rtp_rtcp/*"

BUG=webrtc:6828
NOTRY=True
==========

[mbonadei, 2016-12-22 08:27:45]

mbonadei@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[mbonadei, 2016-12-22 08:27:46]

I decided to split my previous CL in a couple of small CLs.

This is the first one and it address the module 'rtp_rtcp'.

I removed an #include from "	webrtc/modules/rtp_rtcp/include/rtp_rtcp.h" because
it seems unused but please have a double check on that.

Thanks.

[danilchap, 2016-12-22 09:54:38]

https://codereview.webrtc.org/2598963002/diff/1/webrtc/modules/rtp_rtcp/inclu...
File webrtc/modules/rtp_rtcp/include/rtp_rtcp.h (left):

https://codereview.webrtc.org/2598963002/diff/1/webrtc/modules/rtp_rtcp/inclu...
webrtc/modules/rtp_rtcp/include/rtp_rtcp.h:25: #include
"webrtc/modules/video_coding/include/video_coding_defines.h"
It is unused: was added in https://codereview.webrtc.org/1778503002 but was
never used.

[kjellander_webrtc, 2016-12-22 10:34:55]

Make sure to run Chromium trybots on this patch as well.

https://codereview.webrtc.org/2598963002/diff/1/webrtc/modules/rtp_rtcp/BUILD.gn
File webrtc/modules/rtp_rtcp/BUILD.gn (left):

https://codereview.webrtc.org/2598963002/diff/1/webrtc/modules/rtp_rtcp/BUILD...
webrtc/modules/rtp_rtcp/BUILD.gn:23: "mocks/mock_rtp_rtcp.h",
Please add this to the target where it's used; in modules_unittests of
https://chromium.googlesource.com/external/webrtc/+/master/webrtc/modules/BUI...

(long term this should probably move into a target inside webrtc/api instead,
but let's leave that to the owners).

[mbonadei, 2016-12-22 12:24:53]

On 2016/12/22 10:34:55, kjellander_webrtc wrote:
> Make sure to run Chromium trybots on this patch as well.
> 
>
https://codereview.webrtc.org/2598963002/diff/1/webrtc/modules/rtp_rtcp/BUILD.gn
> File webrtc/modules/rtp_rtcp/BUILD.gn (left):
> 
>
https://codereview.webrtc.org/2598963002/diff/1/webrtc/modules/rtp_rtcp/BUILD...
> webrtc/modules/rtp_rtcp/BUILD.gn:23: "mocks/mock_rtp_rtcp.h",
> Please add this to the target where it's used; in modules_unittests of
>
https://chromium.googlesource.com/external/webrtc/+/master/webrtc/modules/BUI...
> 
> (long term this should probably move into a target inside webrtc/api instead,
> but let's leave that to the owners).

I am trying to run them but I get a strange error:

Failed to apply patch for .gn:
While running git apply --index -3 -p2 --verbose;
  error: git diff header lacks filename information when removing 2 leading
pathname components (line 6)

[kjellander_webrtc, 2016-12-22 12:42:58]

On 2016/12/22 12:24:53, mbonadei wrote:
> On 2016/12/22 10:34:55, kjellander_webrtc wrote:
> > Make sure to run Chromium trybots on this patch as well.
> > 
> >
>
https://codereview.webrtc.org/2598963002/diff/1/webrtc/modules/rtp_rtcp/BUILD.gn
> > File webrtc/modules/rtp_rtcp/BUILD.gn (left):
> > 
> >
>
https://codereview.webrtc.org/2598963002/diff/1/webrtc/modules/rtp_rtcp/BUILD...
> > webrtc/modules/rtp_rtcp/BUILD.gn:23: "mocks/mock_rtp_rtcp.h",
> > Please add this to the target where it's used; in modules_unittests of
> >
>
https://chromium.googlesource.com/external/webrtc/+/master/webrtc/modules/BUI...
> > 
> > (long term this should probably move into a target inside webrtc/api
instead,
> > but let's leave that to the owners).
> 
> I am trying to run them but I get a strange error:
> 
> Failed to apply patch for .gn:
> While running git apply --index -3 -p2 --verbose;
>   error: git diff header lacks filename information when removing 2 leading
> pathname components (line 6)

(chatted offline)
it's because Chromium only has the webrtc/ subdirectory, so the .gn change
doesn't apply. The only workaround until
https://bugs.chromium.org/p/chromium/issues/detail?id=611808 is fixed is to make
another patch set without the .gn change, run chromium trybots and then do yet
another patch set with it added again.

[mbonadei, 2016-12-22 14:01:43]

On 2016/12/22 12:42:58, kjellander_webrtc wrote:
> On 2016/12/22 12:24:53, mbonadei wrote:
> > On 2016/12/22 10:34:55, kjellander_webrtc wrote:
> > > Make sure to run Chromium trybots on this patch as well.
> > > 
> > >
> >
>
https://codereview.webrtc.org/2598963002/diff/1/webrtc/modules/rtp_rtcp/BUILD.gn
> > > File webrtc/modules/rtp_rtcp/BUILD.gn (left):
> > > 
> > >
> >
>
https://codereview.webrtc.org/2598963002/diff/1/webrtc/modules/rtp_rtcp/BUILD...
> > > webrtc/modules/rtp_rtcp/BUILD.gn:23: "mocks/mock_rtp_rtcp.h",
> > > Please add this to the target where it's used; in modules_unittests of
> > >
> >
>
https://chromium.googlesource.com/external/webrtc/+/master/webrtc/modules/BUI...
> > > 
> > > (long term this should probably move into a target inside webrtc/api
> instead,
> > > but let's leave that to the owners).
> > 
> > I am trying to run them but I get a strange error:
> > 
> > Failed to apply patch for .gn:
> > While running git apply --index -3 -p2 --verbose;
> >   error: git diff header lacks filename information when removing 2 leading
> > pathname components (line 6)
> 
> (chatted offline)
> it's because Chromium only has the webrtc/ subdirectory, so the .gn change
> doesn't apply. The only workaround until
> https://bugs.chromium.org/p/chromium/issues/detail?id=611808 is fixed is to
make
> another patch set without the .gn change, run chromium trybots and then do yet
> another patch set with it added again.

Done.

Path Set #4 show the results of the chromium trybots and patch Set # 5 shows the
results of webrtc trybots.

[kjellander_webrtc, 2016-12-22 14:20:18]

lgtm, you can safely ignore the purple android trybots as they're currently
broken.

[mbonadei, 2016-12-22 14:31:16]

The CQ bit was checked by mbonadei@webrtc.org

[commit-bot: I haz the power, 2016-12-22 14:31:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-22 14:35:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 14:35:07]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/11708)

[mbonadei, 2016-12-22 14:55:52]

mbonadei@webrtc.org changed reviewers:
+ danilchap@webrtc.org

[mbonadei, 2016-12-22 14:55:53]

Adding Danil to the reviewers for the lgtm from an owner.

https://codereview.webrtc.org/2598963002/diff/1/webrtc/modules/rtp_rtcp/BUILD.gn
File webrtc/modules/rtp_rtcp/BUILD.gn (left):

https://codereview.webrtc.org/2598963002/diff/1/webrtc/modules/rtp_rtcp/BUILD...
webrtc/modules/rtp_rtcp/BUILD.gn:23: "mocks/mock_rtp_rtcp.h",
On 2016/12/22 10:34:54, kjellander_webrtc wrote:
> Please add this to the target where it's used; in modules_unittests of
>
https://chromium.googlesource.com/external/webrtc/+/master/webrtc/modules/BUI...
> 
> (long term this should probably move into a target inside webrtc/api instead,
> but let's leave that to the owners).

Done.

[danilchap, 2016-12-22 15:26:55]

lgtm

[mbonadei, 2016-12-22 15:33:33]

The CQ bit was checked by mbonadei@webrtc.org

[mbonadei, 2016-12-22 15:33:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
danilchap@webrtc.org, kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2598963002/#ps90005 (title:
"Revert "Removing changes in .gn to run chromium trybots"")

[commit-bot: I haz the power, 2016-12-22 15:33:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-22 15:35:39]

CQ is committing da patch.

Bot data: {"patchset_id": 90005, "attempt_start_ts": 1482420813746380,
"parent_rev": "000d16396e748c7593ac41b24a876a6c20f0d277", "commit_rev":
"ebafdc84843256bac7f125ff637d7e006f67d595"}

[commit-bot: I haz the power, 2016-12-22 15:35:41]

Description was changed from

==========
Refactor webrtc/modules/rtp_rtcp for GN check

This moves some GN check configurations out of .gn to individual
targets.

This commit also removes the source file 'mocks/mock_rtp_rtcp.h' from
the static_library 'rtp_rtcp' because it depends on a 'testonly = true'
target. After a check this seems only included in the unitest code:

$ grep -Rn "mocks/mock_rtp_rtcp.h" webrtc/modules/rtp_rtcp/
webrtc/modules/rtp_rtcp/source/ulpfec_receiver_unittest.cc:18:#include
"webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h"
webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc:17:#include
"webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h"

This commit also removes the dependency on
'//webrt/modules/video_coding' because it seems that the following
include can be removed:

#include "webrtc/modules/video_coding/include/video_coding_defines.h"

The now checked target is:
"//webrtc/modules/rtp_rtcp/*"

BUG=webrtc:6828
NOTRY=True
==========

to

==========
Refactor webrtc/modules/rtp_rtcp for GN check

This moves some GN check configurations out of .gn to individual
targets.

This commit also removes the source file 'mocks/mock_rtp_rtcp.h' from
the static_library 'rtp_rtcp' because it depends on a 'testonly = true'
target. After a check this seems only included in the unitest code:

$ grep -Rn "mocks/mock_rtp_rtcp.h" webrtc/modules/rtp_rtcp/
webrtc/modules/rtp_rtcp/source/ulpfec_receiver_unittest.cc:18:#include
"webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h"
webrtc/modules/rtp_rtcp/source/rtp_format_h264_unittest.cc:17:#include
"webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h"

This commit also removes the dependency on
'//webrt/modules/video_coding' because it seems that the following
include can be removed:

#include "webrtc/modules/video_coding/include/video_coding_defines.h"

The now checked target is:
"//webrtc/modules/rtp_rtcp/*"

BUG=webrtc:6828
NOTRY=True

Review-Url: https://codereview.webrtc.org/2598963002
Cr-Commit-Position: refs/heads/master@{#15760}
Committed:
https://chromium.googlesource.com/external/webrtc/+/ebafdc84843256bac7f125ff6...
==========

[commit-bot: I haz the power, 2016-12-22 15:35:42]

Committed patchset #6 (id:90005) as
https://chromium.googlesource.com/external/webrtc/+/ebafdc84843256bac7f125ff6...