Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 2598953002: Revert of Refactor webrtc/modules/desktop_capture for GN check (Closed)

Created:
4 years ago by kjellander (google.com)
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Refactor webrtc/modules/desktop_capture for GN check (patchset #1 id:1 of https://codereview.webrtc.org/2593713002/ ) Reason for revert: Apparently breaks Chromium compile for unknown reason: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/12314 Original issue's description: > Refactor webrtc/modules/desktop_capture for GN check > > This moves some GN check configurations out of .gn to individual > targets. > > The now checked target is: > "//webrtc/modules/desktop_capture/*" > > BUG=webrtc:6828 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2593713002 > Cr-Commit-Position: refs/heads/master@{#15725} > Committed: https://chromium.googlesource.com/external/webrtc/+/70870b921148fdc10d1131958a03d45f0f83f6fa TBR=kjellander@webrtc.org,sergeyu@chromium.org,mbonadei@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -20 lines) Patch
M .gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/desktop_capture/BUILD.gn View 6 chunks +3 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
kjellander (google.com)
Created Revert of Refactor webrtc/modules/desktop_capture for GN check
4 years ago (2016-12-22 07:11:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2598953002/1
4 years ago (2016-12-22 07:11:46 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-12-22 07:11:48 UTC) #5
kjellander_webrtc
lgtm oops, I reverted with my google.com account.
4 years ago (2016-12-22 07:15:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2598953002/1
4 years ago (2016-12-22 07:16:07 UTC) #8
commit-bot: I haz the power
Failed to apply patch for .gn: While running git apply --index -p1; error: patch failed: ...
4 years ago (2016-12-22 07:16:12 UTC) #10
kjellander_webrtc
4 years ago (2016-12-22 07:17:11 UTC) #11
On 2016/12/22 07:16:12, commit-bot: I haz the power wrote:
> Failed to apply patch for .gn:
> While running git apply --index -p1;
>   error: patch failed: .gn:28
>   error: .gn: patch does not apply
> 
> Patch:       .gn
> Index: .gn
> diff --git a/.gn b/.gn
> index
>
7849e32fe939af4c861432df4042d64249fe469c..a0fd50aeada9811738c767ae2275a7ad430c5b48
> 100644
> --- a/.gn
> +++ b/.gn
> @@ -28,7 +28,6 @@
>    "//webrtc/modules/audio_device/*",
>    "//webrtc/modules/audio_mixer/*",
>    "//webrtc/modules/audio_processing/*",
> -  "//webrtc/modules/desktop_capture/*",
>    "//webrtc/modules/video_capture/*",
>    "//webrtc/modules/video_coding/*",
>    "//webrtc/stats:rtc_stats",

I'll revert with my proper account + do a manual revert. Ignore this CL

Powered by Google App Engine
This is Rietveld 408576698