Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2597433002: RTCStatsCollectorTest: Remove ExpectReportContainsDataChannel. (Closed)

Created:
4 years ago by hbos
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

RTCStatsCollectorTest: Remove ExpectReportContainsDataChannel. Remove ExpectReportContainsDataChannel in favor of EXPECT_EQ checks of RTCDataChannelStats objects. BUG=chromium:627816 Review-Url: https://codereview.webrtc.org/2597433002 Cr-Commit-Position: refs/heads/master@{#15731} Committed: https://chromium.googlesource.com/external/webrtc/+/dbb64d8f27e8aaee4e37b6e16503bb5f7406aeed

Patch Set 1 #

Total comments: 1

Patch Set 2 : 3; #

Patch Set 3 : Moved expected stats for clarity (timestamp 0 instead of report->timestamp_us(), ignored in EXPECT_… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -82 lines) Patch
M webrtc/api/rtcstatscollector_unittest.cc View 1 2 23 chunks +97 lines, -80 lines 0 comments Download
M webrtc/api/test/mock_datachannel.h View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
hbos
Please take a look, deadbeef. https://codereview.webrtc.org/2597433002/diff/1/webrtc/api/rtcstatscollector_unittest.cc File webrtc/api/rtcstatscollector_unittest.cc (right): https://codereview.webrtc.org/2597433002/diff/1/webrtc/api/rtcstatscollector_unittest.cc#newcode933 webrtc/api/rtcstatscollector_unittest.cc:933: expected_data_channel3.datachannelid = 3 ; ...
4 years ago (2016-12-20 17:32:10 UTC) #4
Taylor Brandstetter
lgtm
4 years ago (2016-12-20 19:51:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2597433002/20001
4 years ago (2016-12-21 09:30:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2597433002/40001
4 years ago (2016-12-21 09:38:11 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-21 09:57:50 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/dbb64d8f27e8aaee4e37b6e16...

Powered by Google App Engine
This is Rietveld 408576698