Create the DtlsTransportInternal

Create the DtlsTransportInternal

DtlsTransportInternal is an internal interface that does DTLS.
The DtlsTransportChannel will inherit from this class instead of the
TransportChannelImpl so that the ICE-related methods can be separated.

Once the DtlsTransportChannl inherits from this class. It would be
renamed as DtlsTransport.

BUG=none

Review-Url: https://codereview.webrtc.org/2597053002
Cr-Commit-Position: refs/heads/master@{#15888}
Committed: https://chromium.googlesource.com/external/webrtc/+/e50658de850dc7f124bf90f77633d2c6c78e2d0c

[Zhi Huang, 2016-12-22 01:45:18]

Description was changed from

==========
Create the DtlsTransportInternal

DtlsTransportInternal is an internal interface that does DTLS.
The DtlsTransportChannel will inhert from this class instead of the
TransportChannelImpl so that the ICE-related methods can be separated.

Once the DtlsTransportChannl inherits from this class. It would be
renamed as DtlsTransport.

BUG=none
==========

to

==========
Create the DtlsTransportInternal

DtlsTransportInternal is an internal interface that does DTLS.
The DtlsTransportChannel will inherit from this class instead of the
TransportChannelImpl so that the ICE-related methods can be separated.

Once the DtlsTransportChannl inherits from this class. It would be
renamed as DtlsTransport.

BUG=none
==========

[Zhi Huang, 2016-12-22 01:45:53]

Patchset #1 (id:1) has been deleted

[Taylor Brandstetter, 2016-12-22 04:56:20]

deadbeef@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[Taylor Brandstetter, 2016-12-22 04:56:20]

Looks good, I just think we still need transport_name() and component(). Unless
you planned to do something in the next CL that makes them no longer needed

https://codereview.webrtc.org/2597053002/diff/20001/webrtc/p2p/base/dtlstrans...
File webrtc/p2p/base/dtlstransportinternal.h (right):

https://codereview.webrtc.org/2597053002/diff/20001/webrtc/p2p/base/dtlstrans...
webrtc/p2p/base/dtlstransportinternal.h:32: 
I think we'll still need transport_name() and component() for the time being,
since that's how TransportController knows which channel is which. Though in the
future we should change this.

And I guess you could then override debug_name, like you did for
IceTransportInternal.

https://codereview.webrtc.org/2597053002/diff/20001/webrtc/p2p/base/dtlstrans...
webrtc/p2p/base/dtlstransportinternal.h:45: // move away. TODO(zhihuang): Remove
this function.
Nice of you to take over the TODOs. :)

[Zhi Huang, 2016-12-27 19:27:55]

Patchset #2 (id:40001) has been deleted

[Zhi Huang, 2016-12-27 19:33:19]

Please take another look. Thanks.

https://codereview.webrtc.org/2597053002/diff/20001/webrtc/p2p/base/dtlstrans...
File webrtc/p2p/base/dtlstransportinternal.h (right):

https://codereview.webrtc.org/2597053002/diff/20001/webrtc/p2p/base/dtlstrans...
webrtc/p2p/base/dtlstransportinternal.h:32: 
On 2016/12/22 04:56:20, Taylor Brandstetter (OOO) wrote:
> I think we'll still need transport_name() and component() for the time being,
> since that's how TransportController knows which channel is which. Though in
the
> future we should change this.
> 
> And I guess you could then override debug_name, like you did for
> IceTransportInternal.

Agreed and Done.

https://codereview.webrtc.org/2597053002/diff/20001/webrtc/p2p/base/dtlstrans...
webrtc/p2p/base/dtlstransportinternal.h:45: // move away. TODO(zhihuang): Remove
this function.
On 2016/12/22 04:56:20, Taylor Brandstetter (OOO) wrote:
> Nice of you to take over the TODOs. :)

Hope we can finish these TODOs soon so that it won't need another person to take
over in the future. :)

[Taylor Brandstetter, 2016-12-28 19:35:43]

lgtm

[Zhi Huang, 2017-01-03 18:29:24]

The CQ bit was checked by zhihuang@webrtc.org

[commit-bot: I haz the power, 2017-01-03 18:29:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-03 19:34:13]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483468164228020,
"parent_rev": "ce723453c0adc4aecdf2cd4f4a0c579b2332bc98", "commit_rev":
"e50658de850dc7f124bf90f77633d2c6c78e2d0c"}

[commit-bot: I haz the power, 2017-01-03 19:34:16]

Description was changed from

==========
Create the DtlsTransportInternal

DtlsTransportInternal is an internal interface that does DTLS.
The DtlsTransportChannel will inherit from this class instead of the
TransportChannelImpl so that the ICE-related methods can be separated.

Once the DtlsTransportChannl inherits from this class. It would be
renamed as DtlsTransport.

BUG=none
==========

to

==========
Create the DtlsTransportInternal

DtlsTransportInternal is an internal interface that does DTLS.
The DtlsTransportChannel will inherit from this class instead of the
TransportChannelImpl so that the ICE-related methods can be separated.

Once the DtlsTransportChannl inherits from this class. It would be
renamed as DtlsTransport.

BUG=none

Review-Url: https://codereview.webrtc.org/2597053002
Cr-Commit-Position: refs/heads/master@{#15888}
Committed:
https://chromium.googlesource.com/external/webrtc/+/e50658de850dc7f124bf90f77...
==========

[commit-bot: I haz the power, 2017-01-03 19:34:16]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/e50658de850dc7f124bf90f77...