Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Issue 2595533002: Add back video_replay. Disappeared in the gn conversion. (Closed)

Created:
4 years ago by stefan-webrtc
Modified:
4 years ago
Reviewers:
philipel
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add back video_replay. Disappeared in the gn conversion. BUG=webrtc:6323 Review-Url: https://codereview.webrtc.org/2595533002 Cr-Commit-Position: refs/heads/master@{#15715} Committed: https://chromium.googlesource.com/external/webrtc/+/64427e563ef80d16798a1d13387bf6d361028eb2

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -24 lines) Patch
M webrtc/test/rtp_file_reader.cc View 1 10 chunks +14 lines, -21 lines 0 comments Download
M webrtc/video/BUILD.gn View 2 chunks +22 lines, -2 lines 0 comments Download
M webrtc/video/replay.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
stefan-webrtc
4 years ago (2016-12-20 12:49:06 UTC) #2
philipel
lgtm with one minor comment. https://codereview.webrtc.org/2595533002/diff/1/webrtc/test/rtp_file_reader.cc File webrtc/test/rtp_file_reader.cc (right): https://codereview.webrtc.org/2595533002/diff/1/webrtc/test/rtp_file_reader.cc#newcode34 webrtc/test/rtp_file_reader.cc:34: LOG(LS_INFO) << "FAIL at ...
4 years ago (2016-12-20 13:06:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2595533002/20001
4 years ago (2016-12-20 14:11:44 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-20 15:27:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/64427e563ef80d16798a1d133...

Powered by Google App Engine
This is Rietveld 408576698