Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2595283003: Fix an error in Audio Network Adaptor: time constant passed wrong. (Closed)

Created:
4 years ago by minyue-webrtc
Modified:
3 years, 12 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix an error in Audio Network Adaptor: time constant passed wrong. BUG=wbrtc:6303 Review-Url: https://codereview.webrtc.org/2595283003 Cr-Commit-Position: refs/heads/master@{#15767} Committed: https://chromium.googlesource.com/external/webrtc/+/d01ed1fe8f5c67d90b97fd34d9eda5e2c1e29ec8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
minyue-webrtc
Hi Michael, Please take a look. We can consider adding a test later. But shall ...
4 years ago (2016-12-22 12:44:57 UTC) #3
michaelt
lgtm
4 years ago (2016-12-22 13:18:36 UTC) #4
minyue-webrtc
Hi Henrik, Here is fix to an error in ANA. Please also take a look.
4 years ago (2016-12-22 13:37:54 UTC) #6
hlundin-webrtc
lgtm
4 years ago (2016-12-22 13:41:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2595283003/1
4 years ago (2016-12-22 14:08:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_x64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x64_dbg/builds/10052)
4 years ago (2016-12-22 14:12:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2595283003/1
3 years, 12 months ago (2016-12-23 09:37:23 UTC) #13
commit-bot: I haz the power
3 years, 12 months ago (2016-12-23 09:49:41 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/d01ed1fe8f5c67d90b97fd34d...

Powered by Google App Engine
This is Rietveld 408576698